Repository navigation
FIX: keep line breaks in image text converters - #3474
Open
Utkarsh Bahuguna (u7k4rs6) wants to merge 2 commits into
Open
Utkarsh Bahuguna (u7k4rs6) wants to merge 2 commits into
Utkarsh Bahuguna (u7k4rs6) wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image text converters wrapped text with textwrap.fill, which turns newlines into spaces, so multi-line text got drawn as one paragraph. This wraps each line separately, so line breaks and blank lines show up in the image and long lines still wrap. The new tests go through convert_async for all three converters and fail on main.
Fixes #3473