Repository navigation
FIX: restart finding evidence pagination on each opening - #3633
Open
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Open
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the linked issue
The reopen reset cleared the selection, notice, and attach error but left the pagination offset and title filter in place, so a later opening fetched the previous opening's page and search and could show an empty list for an operation that has findings. The reopen reset now also returns to the first page with an empty filter, matching what the dialog already does when the operation changes or a search is typed.
Tests and Documentation
Added a regression test that pages forward, cancels, reopens, and asserts the findings request goes back to offset 0 with an empty title. It fails on main and passes with the change. The full dialog suite passes (23 tests) and tsc is clean.
No documentation change needed, so I did not run JupyText.