Repository navigation
FIX: report unknown planned for an empty count combination - #3637
Open
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Open
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3636
The
plannedsum was guarded by anall()that is vacuously true over an empty input, so combining zero count sets returnedplanned=0instead of the documented None for unknown. The guard now also requires a nonempty input, so an empty group reports no plan rather than a zero plan. A nonempty input with any missing planned count behaves exactly as before.Tests and Documentation
Added a regression test asserting an empty combination reports
planned=None. It fails on main, which returns 0, and passes with the change. The full analytics suite passes (572 tests).No documentation change needed, so I did not run JupyText.