Skip to content

Conversation

@frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Nov 14, 2025

Fixes #5858.

Unblocked libcxx test(s):

  • std/utilities/template.bitset/bitset.cons/string_ctor.pass.cpp

@StephanTLavavej StephanTLavavej added the LWG Library Working Group issue label Nov 14, 2025
@StephanTLavavej
Copy link
Member

Examining the test artifacts:

C:\Users\stl\Downloads>py D:\GitHub\STL\tools\scripts\print_failures.py test-results.xml
name: libc++.std/utilities/template_bitset/bitset_cons
No output, possibly because this was an XPASS.

@StephanTLavavej StephanTLavavej moved this from Initial Review to Work In Progress in STL Code Reviews Nov 14, 2025
@frederick-vs-ja
Copy link
Contributor Author

frederick-vs-ja commented Nov 14, 2025

Examining the test artifacts:

C:\Users\stl\Downloads>py D:\GitHub\STL\tools\scripts\print_failures.py test-results.xml
name: libc++.std/utilities/template_bitset/bitset_cons
No output, possibly because this was an XPASS.

Ah, thanks! The XPASS test is std/utilities/template.bitset/bitset.cons/string_ctor.pass.cpp.

This test expects that bitset isn't constructible from non-trivially-copyable Nonsense type in the immediate context, which is the result of LWG-4294.
https://github.com/llvm/llvm-project/blob/e02fdf0fcea3c02dc0eb692bc38042f9681e4afd/libcxx/test/std/utilities/template.bitset/bitset.cons/string_ctor.pass.cpp#L128-L134
And previously we treated that as non-Standard behavior.

# Testing nonstandard behavior
std/utilities/template.bitset/bitset.cons/string_ctor.pass.cpp FAIL

@StephanTLavavej StephanTLavavej moved this from Work In Progress to Initial Review in STL Code Reviews Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LWG Library Working Group issue

Projects

Status: Initial Review

Development

Successfully merging this pull request may close these issues.

LWG-4294 bitset(const CharT*) constructor needs to be constrained

2 participants