-
Notifications
You must be signed in to change notification settings - Fork 36
Add generator option for newlines between statements #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@microsoft-github-policy-service agree |
llali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the new option is not added to SqlScriptGeneratorOptions so this will have build error.
|
Please also add tests to verify the new option |
Hi, I'm not sure what you mean, it was added to the .xml file. As far as I can see there is no tracked .cs equivalent to be generated rather it is generated at build time. When I built and tested locally it worked for me |
Where should this go? I don't see any current tests for SQL generation |
|
@llali can I get an update on this? |
you are right my bad. |
Please add test for this new option. Thanks |
I've added a test |
Currently the generator only generates one newline between statements which leads to code like this:
Which can be unfavourable, I've added a script generator option that allows you to specify how many newlines you want so you can get something like this instead: