fix: prevent UnboundLocalError in ExperienceSummarizer.get_summary#310
Open
nuthalapativarun wants to merge 1 commit intomicrosoft:pre-releasefrom
Open
Conversation
When json_parser raises an exception, response_json is set to None and the summary dict is never initialized, causing an UnboundLocalError on the return statement. Initialize summary before the conditional block so it is always defined. Also replace bare except with except Exception. Fixes microsoft#189
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnboundLocalError: cannot access local variable 'summary'inExperienceSummarizer.get_summaryexcept:withexcept Exception:Changes
ufo/experience/summarizer.py— whenjson_parserraises an exception,response_jsonis set toNoneand thesummarydict is never initialized inside theif response_json:block. The subsequentreturn summary, costthen raisesUnboundLocalError.Fix: initialize
summary = dict()before the conditional block so it is always defined regardless of whetherjson_parsersucceeds.Reproduction
Occurs when the LLM returns a non-JSON response during experience summarization.
Related Issue
Fixes #189