fix: replace bare except clause in ClaudeService.chat_completion#311
Open
nuthalapativarun wants to merge 1 commit intomicrosoft:pre-releasefrom
Open
fix: replace bare except clause in ClaudeService.chat_completion#311nuthalapativarun wants to merge 1 commit intomicrosoft:pre-releasefrom
nuthalapativarun wants to merge 1 commit intomicrosoft:pre-releasefrom
Conversation
Bare except clauses catch SystemExit and KeyboardInterrupt in addition to regular exceptions. Replace with except Exception in the fallback response logging block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
except:withexcept Exception:inClaudeService.chat_completionChanges
ufo/llm/claude.py— the fallbacktry/exceptblock that logs the rawresponseobject on API error used a bareexcept:clause. Changed toexcept Exception:to avoid suppressingSystemExitorKeyboardInterrupt.The outer exception handler already uses
except Exception as e(correct); this aligns the inner fallback with the same pattern.