fix: relax faiss-cpu and numpy version pins for Python 3.13 compatibility#314
Open
nuthalapativarun wants to merge 1 commit intomicrosoft:pre-releasefrom
Open
Conversation
faiss-cpu==1.8.0 is not published for Python 3.13 (first compatible wheel is 1.9.0.post1). numpy==1.26.4 conflicts with langchain-community which requires numpy>=2.1.0 on Python 3.13. Relax both to >= lower bounds so pip can resolve the correct version for the running Python interpreter without breaking existing setups. Fixes microsoft#254
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
faiss-cpuandnumpyversion pins to allow installation on Python 3.13Changes
requirements.txt:faiss-cpu==1.8.0→faiss-cpu>=1.9.0— version 1.8.0 has no published wheel for Python 3.13; first compatible release is 1.9.0.post1numpy==1.26.4→numpy>=1.26.4—langchain-communityrequiresnumpy>=2.1.0on Python 3.13; pinning to 1.26.4 causes a resolution conflictBoth changes use
>=lower bounds so existing Python 3.10/3.11/3.12 setups continue to install the same versions they do today (pip resolves the minimum satisfying version), while Python 3.13 users get a compatible wheel.Related Issue
Fixes #254