Repository navigation
Sync feature/compose with latest master - #42274
David Bennett (dkbennett) merged 376 commits into
Conversation
* Use iterators in FromJson to avoid copies * Cleanup * Fix template build * Format
* Refine sparse VHD creation policy Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Enable experimental sparse VHD creation in WSL Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Make sparse VHD unsafe flag optional Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Keep fixed VHD creation non-sparse Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…2.7391 (#41730) Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
…l disks (#41678) * Update the DACL to only allow access to the user when creating virtual disks * Save state * Increase test coverage * Fix test * Apply PR feedback * Apply PR feedback * Format * Apply PR suggestions * Apply PR suggestions
Add translator guidance distinguishing container images from pictures or photos for the affected WSLC strings. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com> Copilot-Session: 88d3d4b4-5a0e-4d97-9ed4-0fcd856e61de
* Add RLCPlus-9 and RLCPlus-10 (Rocky Linux Plus, CIQ) * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Re-trigger CI: xattr check confirmed clean (no security.selinux attributes found), all four combinations remain boot-tested --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This is an automated release [1]. [1] https://gitlab.archlinux.org/archlinux/archlinux-wsl/-/blob/main/.gitlab-ci.yml
* Enable automatic vNUMA for WSL VMs Add the HCS NUMA topology object so HCS can derive a supported virtual topology for large processor counts instead of requiring WSL to clamp the VM to 256 processors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ea0c67c5-0211-479b-a7b5-59aebb19b71c * Gate automatic vNUMA on Germanium Preserve the existing single-node HCS configuration on older Windows builds where vNUMA topology creation is unsupported. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ea0c67c5-0211-479b-a7b5-59aebb19b71c * Remove vNUMA test coverage Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ea0c67c5-0211-479b-a7b5-59aebb19b71c --------- Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com> Copilot-Session: ea0c67c5-0211-479b-a7b5-59aebb19b71c
* Exclude wslc.exe and wslcsession.exe from custom LSP providers * Include container.exe
Co-authored-by: WSL localization <noreply@microsoft.com>
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Save state * Increase test coverage * Remove useless state
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…service and common filesystem helpers (#41668) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: WSL localization <noreply@microsoft.com>
* Update issue tempalte for WSLC * Fix description
* Run the nightly tests on ge-current * Run the nightly tests on Windows Server 2025 * Skip some network tests * Update name * Fix mirrored check * Use the server field
Co-authored-by: WSL localization <noreply@microsoft.com>
…le times on the same test_distro (#41781)
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
#42208) Problem: Unregistering an in-place WSL2 import could delete unrelated sibling rootfs and temp directories because it requested cleanup of all storage artifacts, including WSL1 directories. Fix: Normal WSL2 unregister now skips WSL1 directory cleanup while still deleting the registered VHD. Conversion cleanup is unchanged.
Problem: Hyphen-leading positional arguments did not advance the positional index, so subsequent operands overwrote them. The increment incorrectly depended on the token’s first character. Fix: Advance the index whenever a positional argument is consumed.
* Add persistent per-container state with restart count tracking Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Delete container state for auto-remove containers removed during recovery Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Reject out-of-range RestartCount and fix restart test run marker race Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Rewrite WSLC container state store around persistence contract Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Delete persisted container state after COM disconnect Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Read persisted state with delete sharing in restart count poll Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Store WSLC container state in the guest via WSLC_READ_FILE / atomic WSLC_WRITE_FILE Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Use E_FAIL for guest errno failures in container state store Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Avoid blocking on non-regular files in guest state read/write Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Use single Update method for container state store and document per-container scope Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Throw from ReadGuestFile and state store loads, drop ContentLength, rename state file Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Newly released SLE 16.0 QU4 available here -> https://github.com/SUSE/WSL-instarball/releases/tag/v20261110.0
Co-authored-by: WSL localization <noreply@microsoft.com>
* Don't prevent guest-only binds in consommé networking mode * Use well known IP for negative test
* Throw from WriteGuestFile on guest failure Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Throw localized error from WriteGuestFile Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Problem: Interface-state ioctl notifications bypassed the port tracker’s queue and raced with port-release requests on a shared channel without transaction-wide serialization, causing errors or lost replies. Fix: Route ioctl notifications through the existing tracker queue, serializing their request/reply exchanges with port allocation and release.
Co-authored-by: WSL localization <noreply@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bdbeff06-c914-4ed9-81fc-cd328da67817
…irtiofs shares (#42243) * Add missing synchronization around init channel usage when mounting virtiofs shares * Cleanup diff * Relock on delete --------- Co-authored-by: Pooja Trivedi <poojatrivedi@gmail.com>
Co-authored-by: Pooja Trivedi <poojatrivedi@gmail.com>
There was a problem hiding this comment.
🟡 Changes recommended
An active review finding requests replacing the bare failure check at WslCoreGuestNetworkService.cpp:147 with WIL failure handling to match the file’s existing HCN error-handling pattern.
1 open issue
What changed in this PR
Syncs master into feature/compose, bringing upstream container features, reliability fixes, tests, and documentation into the Compose branch.
Changes:
- Adds container networking APIs, capability options, restart-policy support, and CLI compatibility improvements.
- Improves process, session, networking, filesystem, and resource-lifetime handling across Windows and Linux components.
- Updates regression tests, API documentation, dependencies, diagnostics, and release pipelines.
| File | Description |
|---|---|
| tools/devops/requirements.txt | Updates GitPython dependency. |
| test/windows/wslc/WSLCRestartSchedulerUnitTests.cpp | Tests callback cleanup during scheduler shutdown. |
| test/windows/wslc/WSLCE2ENetworkInspectTests.cpp | Tests network inspection by ID and prefix. |
| test/windows/wslc/WSLCE2EGlobalTests.cpp | Tests session commands with NUL stdin. |
| test/windows/wslc/WSLCE2EContainerRemoveTests.cpp | Tests forced removal of missing containers. |
| test/windows/wslc/WSLCE2EContainerInspectTests.cpp | Tests inspection-name round trips. |
| test/windows/wslc/ParserTestCases.h | Adds end-of-options parsing cases. |
| test/windows/wslc/CMakeLists.txt | Reformats test source registration. |
| test/windows/wsl/PolicyTests.cpp | Tests mirrored-networking policy precedence. |
| test/windows/wsl/PluginTests.h | Adds isolation and teardown test identifiers. |
| test/windows/wsl/Plan9Tests.cpp | Tests truncation after Linux file replacement. |
| test/windows/common/WSLCE2EHelpers.h | Declares VM inspection and termination helpers. |
| test/windows/common/StringUnitTests.cpp | Tests scoped IPv6 address formatting. |
| test/windows/common/Common.h | Extends test helpers and handle wrapping. |
| test/windows/CMakeLists.txt | Adds VM backend test dependencies and artifacts. |
| test/linux/unit_tests/wslpath.c | Expands Unicode path-escaping coverage. |
| test/linux/unit_tests/mremap.c | Supplies missing diagnostic argument. |
| test/linux/unit_tests/lxtutil.c | Pins file identity before reading. |
| test/linux/unit_tests/lxtfs.c | Supplies file-creation mode argument. |
| src/windows/wslsettings/Views/OOBE/GeneralPage.xaml.cs | Unsubscribes when leaving or unloading the page. |
| src/windows/wslsettings/LibWsl.cs | Frees nested strings before their owning allocation. |
| src/windows/wslsettings/Contracts/Services/IWslConfigService.cs | Adds saved-value and immediate-commit contracts. |
| src/windows/wslrelay/localhost.cpp | Avoids retaining listening sockets in connection workers. |
| src/windows/wslcsession/WSLCVolumes.cpp | Clarifies volume-event comments only. |
| src/windows/wslcsession/WSLCSharedLockGate.h | Adds termination-aware shared locking. |
| src/windows/wslcsession/WSLCSessionRuntime.h | Clarifies event and termination comments only. |
| src/windows/wslcsession/WSLCSessionReference.h | Adopts guarded COM lifetime handling. |
| src/windows/wslcsession/WSLCSessionFactory.h | Removes destruction-callback interface. |
| src/windows/wslcsession/WSLCSessionFactory.cpp | Registers service references and enables process waits. |
| src/windows/wslcsession/WSLCRestartTransaction.h | Adds restart-transaction ownership cleanup. |
| src/windows/wslcsession/WSLCRestartBackoff.h | Adds bounded exponential restart delays. |
| src/windows/wslcsession/WSLCProcessIO.h | Declares locks for process I/O handles. |
| src/windows/wslcsession/WSLCProcessIO.cpp | Serializes process-handle access. |
| src/windows/wslcsession/WSLCProcessControl.h | Adds weak process-registry tracking. |
| src/windows/wslcsession/WSLCProcessControl.cpp | Improves process cleanup and TTY termination handling. |
| src/windows/wslcsession/WSLCNetworkMetadata.h | Adds IPv6 and resolved-network metadata. |
| src/windows/wslcsession/WSLCContainerMetadata.h | Adds restart-policy and state-storage metadata. |
| src/windows/wslcsession/DockerHTTPClient.h | Replaces prune declaration with candidate listing. |
| src/windows/wslcsession/CMakeLists.txt | Updates session state and lifecycle sources. |
| src/windows/WslcSDK/wslcsdk.def | Exports networking, capability, and loopback APIs. |
| src/windows/WslcSDK/winrt/SessionSettings.h | Declares host-loopback settings. |
| src/windows/WslcSDK/winrt/SessionSettings.cpp | Converts host-loopback settings to native options. |
| src/windows/WslcSDK/winrt/Session.h | Adds network APIs and termination-handler tracking. |
| src/windows/WslcSDK/winrt/precomp.h | Includes new network wrappers. |
| src/windows/WslcSDK/winrt/NetworkSettings.h | Defines network-creation settings wrapper. |
| src/windows/WslcSDK/winrt/NetworkInfo.h | Defines network metadata wrapper. |
| src/windows/WslcSDK/winrt/ContainerNetwork.h | Defines container network attachment settings. |
| src/windows/WslcSDK/winrt/Container.h | Declares network connect and disconnect methods. |
| src/windows/WslcSDK/winrt/Container.cpp | Adds network methods and corrects close ordering. |
| src/windows/WslcSDK/winrt/CMakeLists.txt | Registers network wrapper sources. |
| src/windows/wslc/tasks/InspectTasks.cpp | Renames network parameter to reflect ID support. |
| src/windows/wslc/services/SessionService.cpp | Updates Docker-compatible event fields. |
| src/windows/wslc/services/NetworkService.h | Clarifies network name-or-ID parameters. |
| src/windows/wslc/services/NetworkModel.h | Adds IPv6 creation option. |
| src/windows/wslc/services/ConsoleService.cpp | Distinguishes consoles from NUL and uses wide detach keys. |
| src/windows/wslc/core/Command.h | Exposes end-of-options parsing state. |
| src/windows/wslc/core/Command.cpp | Propagates end-of-options state through parsing. |
| src/windows/wslc/commands/SystemEventsCommand.cpp | Uses system-event help resources. |
| src/windows/wslc/commands/RootCommand.cpp | Registers root-level copy command. |
| src/windows/wslc/commands/NetworkRemoveCommand.cpp | Accepts network names or IDs. |
| src/windows/wslc/commands/NetworkInspectCommand.cpp | Accepts network names or IDs. |
| src/windows/wslc/commands/NetworkDisconnectCommand.cpp | Accepts network names or IDs. |
| src/windows/wslc/commands/NetworkCreateCommand.cpp | Exposes IPv6 option. |
| src/windows/wslc/commands/NetworkConnectCommand.cpp | Accepts network names or IDs. |
| src/windows/wslc/commands/ContainerRunCommand.cpp | Adds capabilities and restart-option validation. |
| src/windows/wslc/commands/ContainerCreateCommand.cpp | Adds capabilities and restart-option validation. |
| src/windows/wslc/commands/ContainerCpCommand.cpp | Changes copy-command help resource. |
| src/windows/wslc/commands/ContainerCommand.h | Declares create/run argument validation. |
| src/windows/wslc/arguments/SpecParsing.h | Declares restart-policy parsing. |
| src/windows/wslc/arguments/ArgumentValidation.cpp | Validates restart policies and improves mount errors. |
| src/windows/wslc/arguments/ArgumentParser.h | Tracks end-of-options state. |
| src/windows/wslc/arguments/ArgumentConvertedTypes.h | Adds converted restart-policy type. |
| src/windows/service/exe/WSLCSessionManagerFactory.h | Declares lifetime-safe session lookup. |
| src/windows/service/exe/WslCoreInstance.h | Adds instance ID access and shared completion event. |
| src/windows/service/exe/WslCoreGuestNetworkService.cpp | Retries smaller ephemeral port ranges with warnings. |
| src/windows/service/exe/PluginManager.h | Adds synchronized per-plugin session tracking. |
| src/windows/service/exe/MirroredNetworking.cpp | Stops port tracking earlier during teardown. |
| src/windows/service/exe/LxssInstance.h | Adds process-creation and initialization synchronization. |
| src/windows/service/exe/LxssCreateProcess.h | Sends plugin identity with process requests. |
| src/windows/service/exe/HcsVirtualMachine.h | Adds guarded COM lifetime and exit-report tracking. |
| src/windows/inc/WslPluginApi.h | Clarifies plugin VM-lease documentation. |
| src/windows/inc/RegistryWatcher.h | Prevents wait rearming during destruction. |
| src/windows/common/wslutil.h | Adds optional leading-slash name validation. |
| src/windows/common/WSLCRestartScheduler.h | Defines delayed restart callback scheduler. |
| src/windows/common/WslCoreFilesystem.cpp | Enables encrypted VHD support on supported Windows builds. |
| src/windows/common/WslCoreConfig.h | Removes NAT identity accessor declarations. |
| src/windows/common/WslClient.cpp | Applies running-distribution filtering before verbose output. |
| src/windows/common/wslc/models/ContainerModel.h | Adds restart and capability options. |
| src/windows/common/wslc/models/ContainerModel.cpp | Adds context to volume parsing errors. |
| src/windows/common/WindowsUpdateIntegration.cpp | Always supplies required progress callbacks. |
| src/windows/common/timestamp.hpp | Declares flexible timestamp parsing. |
| src/windows/common/string.hpp | Adds IP address formatting declarations. |
| src/windows/common/RuntimeClass.h | Guards module references during constructor failure. |
| src/windows/common/RingBuffer.cpp | Corrects delimiter and wrapped-line extraction. |
| src/windows/common/relay.hpp | Disables relay move construction. |
| src/windows/common/MountSpecParsing.h | Adds mount modes and config-volume metadata. |
| src/windows/common/interop.cpp | Corrects HRESULT-to-Linux error mapping. |
| src/windows/common/install.cpp | Reports Windows Installer contention explicitly. |
| src/windows/common/helpers.cpp | Removes forced global DMA bounce buffering. |
| src/windows/common/HandleIO.h | Uses wide characters for detach sequences. |
| src/windows/common/HandleIO.cpp | Matches detach sequences against Unicode input. |
| src/windows/common/GnsPortTrackerChannel.cpp | Validates interface-name termination. |
| src/windows/common/ExecutionContext.h | Removes constructor’s nonthrowing declaration. |
| src/windows/common/ExecutionContext.cpp | Allows service-context construction errors to propagate. |
| src/windows/common/DnsTunnelingChannel.h | Declares explicit receive-worker startup. |
| src/windows/common/DnsTunnelingChannel.cpp | Separates worker startup from construction. |
| src/windows/common/DeviceHostProxy.h | Adds guarded lifetime and filesystem removal API. |
| src/windows/common/DeviceHostProxy.cpp | Implements remote filesystem removal. |
| src/windows/common/ConsommeNetworking.h | Separates IPv4/IPv6 routes and adds DNS watching. |
| src/windows/common/COMImplClass.h | Improves disconnect and caller lifetime ordering. |
| src/windows/common/APICompat.h | Declares extended settings conversions. |
| src/windows/common/APICompat.cpp | Converts capabilities, network settings, and host loopback. |
| src/shared/inc/CommandLine.h | Corrects absolute-path and positional-argument handling. |
| src/linux/plan9/p9xattr.cpp | Applies filesystem user context during xattr commit. |
| src/linux/plan9/p9io.h | Adds tracked epoll registration IDs. |
| src/linux/plan9/p9io.cpp | Synchronizes epoll dispatcher registration and notification. |
| src/linux/plan9/p9fs.cpp | Rejects invalid root user IDs. |
| src/linux/plan9/p9file.cpp | Locks file copying and preserves truncation identity. |
| src/linux/init/WslDistributionConfig.h | Removes kernel performance-path setting. |
| src/linux/init/SecCompDispatcher.h | Adds explicit dispatcher startup and termination input. |
| src/linux/init/plan9.cpp | Restores umask after setup. |
| src/linux/init/localhost.cpp | Routes interface notifications through port tracking. |
| src/linux/init/GnsPortTracker.h | Declares interface-state notification handling. |
| src/linux/init/GnsPortTracker.cpp | Handles interface changes in the tracker loop. |
| src/linux/init/escape.cpp | Restricts unescaping to the intended Unicode range. |
| src/linux/init/DnsServer.cpp | Suppresses SIGPIPE during TCP DNS sends. |
| src/linux/init/common.h | Adds debug checks before cloning. |
| packages.config | Updates runtime, device host, and kernel packages. |
| nuget/Microsoft.WSL.Containers/manifests/Microsoft.WSL.Containers.manifest | Registers new WinRT network classes. |
| intune/zh-CN/WSL.adml | Updates Chinese capability-policy explanation. |
| intune/sv-SE/WSL.adml | Updates Swedish capability-policy explanation. |
| intune/ru-RU/WSL.adml | Updates Russian capability-policy explanation. |
| intune/pt-PT/WSL.adml | Updates Portuguese capability-policy explanation. |
| intune/pt-BR/WSL.adml | Updates Brazilian Portuguese capability-policy explanation. |
| intune/nl-NL/WSL.adml | Updates Dutch capability-policy explanation. |
| intune/nb-NO/WSL.adml | Updates Norwegian capability-policy explanation. |
| intune/it-IT/WSL.adml | Updates Italian capability-policy explanation. |
| intune/fr-FR/WSL.adml | Updates French capability-policy explanation. |
| intune/es-ES/WSL.adml | Updates Spanish capability-policy explanation. |
| intune/en-US/WSL.adml | Documents capability additions under privileged-container policy. |
| intune/en-GB/WSL.adml | Updates British English capability-policy explanation. |
| intune/de-DE/WSL.adml | Updates German capability-policy explanation. |
| doc/docs/dev-loop.md | Clarifies full-build and elevated-test requirements. |
| doc/docs/api-reference/csharp/settings-classes/sessionsettings.md | Documents host-loopback settings. |
| doc/docs/api-reference/csharp/settings-classes/networksettings.md | Documents network-creation settings. |
| doc/docs/api-reference/csharp/settings-classes/index.md | Links network settings reference. |
| doc/docs/api-reference/csharp/settings-classes/containersettings.md | Documents networks and capability collections. |
| doc/docs/api-reference/csharp/settings-classes/.pages | Adds network settings navigation. |
| doc/docs/api-reference/csharp/enumerations/networkflags.md | Documents network flags. |
| doc/docs/api-reference/csharp/enumerations/index.md | Links network flags reference. |
| doc/docs/api-reference/csharp/enumerations/error.md | Adds capability, runtime, and network errors. |
| doc/docs/api-reference/csharp/enumerations/.pages | Adds network flags navigation. |
| doc/docs/api-reference/csharp/data-classes/networkinfo.md | Documents network metadata. |
| doc/docs/api-reference/csharp/data-classes/index.md | Links new network data classes. |
| doc/docs/api-reference/csharp/data-classes/containernetwork.md | Documents network attachment settings. |
| doc/docs/api-reference/csharp/data-classes/.pages | Adds network data-class navigation. |
| doc/docs/api-reference/csharp/core-classes/session.md | Documents session network management. |
| doc/docs/api-reference/csharp/core-classes/container.md | Documents network connection methods. |
| doc/docs/api-reference/cpp/settings-classes/sessionsettings.md | Documents host-loopback settings. |
| doc/docs/api-reference/cpp/settings-classes/networksettings.md | Documents network-creation settings. |
| doc/docs/api-reference/cpp/settings-classes/index.md | Links network settings reference. |
| doc/docs/api-reference/cpp/settings-classes/containersettings.md | Documents networks and capabilities. |
| doc/docs/api-reference/cpp/settings-classes/.pages | Adds network settings navigation. |
| doc/docs/api-reference/cpp/enumerations/networkflags.md | Documents network flags. |
| doc/docs/api-reference/cpp/enumerations/index.md | Links network flags reference. |
| doc/docs/api-reference/cpp/enumerations/error.md | Adds capability, runtime, and network errors. |
| doc/docs/api-reference/cpp/enumerations/.pages | Adds network flags navigation. |
| doc/docs/api-reference/cpp/data-classes/networkinfo.md | Documents network metadata wrapper. |
| doc/docs/api-reference/cpp/data-classes/index.md | Links new network data classes. |
| doc/docs/api-reference/cpp/data-classes/containernetwork.md | Documents network attachment settings. |
| doc/docs/api-reference/cpp/data-classes/.pages | Adds network data-class navigation. |
| doc/docs/api-reference/cpp/core-classes/session.md | Documents session network management. |
| doc/docs/api-reference/cpp/core-classes/container.md | Documents network connection methods. |
| doc/docs/api-reference/c/structures/wslcnetworksettings.md | Documents native network settings. |
| doc/docs/api-reference/c/structures/wslcnetworkinfo.md | Documents native network metadata. |
| doc/docs/api-reference/c/structures/wslccontainernetwork.md | Documents native network attachment structure. |
| doc/docs/api-reference/c/structures/index.md | Links new network structures. |
| doc/docs/api-reference/c/structures/constants.md | Updates option sizes and network constants. |
| doc/docs/api-reference/c/structures/.pages | Adds network structure navigation. |
| doc/docs/api-reference/c/session-apis/wslcsetsessionsettingshostloopback.md | Documents host-loopback API. |
| doc/docs/api-reference/c/session-apis/wslccreatesession.md | Documents runtime compatibility failures. |
| doc/docs/api-reference/c/session-apis/index.md | Links host-loopback API. |
| doc/docs/api-reference/c/session-apis/.pages | Adds host-loopback navigation. |
| doc/docs/api-reference/c/network-apis/wslclistsessionnetworks.md | Documents network listing and memory ownership. |
| doc/docs/api-reference/c/network-apis/wslcdeletesessionnetwork.md | Documents network deletion and lookup rules. |
| doc/docs/api-reference/c/network-apis/wslccreatesessionnetwork.md | Documents network creation and validation. |
| doc/docs/api-reference/c/network-apis/index.md | Introduces network API index. |
| doc/docs/api-reference/c/network-apis/.pages | Defines network API navigation. |
| doc/docs/api-reference/c/index.md | Adds network APIs to reference overview. |
| doc/docs/api-reference/c/enumerations/wslcnetworkflags.md | Documents native network flags. |
| doc/docs/api-reference/c/enumerations/index.md | Links native network flags. |
| doc/docs/api-reference/c/enumerations/.pages | Adds native network flags navigation. |
| doc/docs/api-reference/c/container-apis/wslcsetcontainersettingsnetworkingmode.md | Documents defaults and conflicting settings. |
| doc/docs/api-reference/c/container-apis/wslcsetcontainersettingscapabilitydrops.md | Documents capability removal API. |
| doc/docs/api-reference/c/container-apis/wslcsetcontainersettingscapabilityadditions.md | Documents capability addition API. |
| doc/docs/api-reference/c/container-apis/wslcdisconnectcontainernetwork.md | Documents network disconnection API. |
| doc/docs/api-reference/c/container-apis/wslccreatecontainer.md | Documents settings validation and runtime requirements. |
| doc/docs/api-reference/c/container-apis/wslcconnectcontainernetwork.md | Documents network connection API. |
| doc/docs/api-reference/c/container-apis/index.md | Links networking and capability APIs. |
| doc/docs/api-reference/c/container-apis/.pages | Adds networking and capability navigation. |
| doc/docs/api-reference/c/.pages | Adds network API section. |
| distributions/requirements.txt | Updates GitPython dependency. |
| diagnostics/collect-wsl-logs.ps1 | Preserves logs when archive creation fails. |
| CMakeLists.txt | Uses explicit module includes and increases committed stack. |
| cmake/findNuget.cmake | Selects repository NuGet configuration explicitly. |
| .pipelines/wsl-build-release-onebranch.yml | Adds explicit publishing controls. |
| .pipelines/package-stage.yml | Blocks publishing from manual validation runs. |
| .pipelines/dcat-download-steps.yml | Adds explicit artifact download template. |
| .pipelines/dcat-audience-job.yml | Uses custom release pool and explicit downloads. |
| .github/policies/resourceManagement.yml | Adds permission-gated Hyper-V issue redirection. |
Review effort: Balanced
| if (FAILED(result)) | ||
| { | ||
| if (portRangeSize < c_minEphemeralPortRangeSize) | ||
| { | ||
| EMIT_USER_WARNING(Localization::MessageMirroredNetworkingPortRangeAllocationFailed(c_minEphemeralPortRangeSize + 1)); | ||
| } | ||
| THROW_HR(result); | ||
| } |
ranm-msft
left a comment
There was a problem hiding this comment.
One focused follow-up on the merged code.
| auto vmLease = m_session.Runtime().AcquireVmLease(); | ||
| return CallImpl(&WSLCContainerImpl::Exec, Options, StartOptions, Process); | ||
| } | ||
| CATCH_RETURN(); | ||
|
|
||
| HRESULT WSLCContainer::Stop(_In_ WSLCSignal Signal, _In_ LONG TimeoutSeconds) | ||
| { | ||
| auto sessionLifetime = ResolveSession(); |
There was a problem hiding this comment.
[P2] ResolveSession() can throw RPC_E_DISCONNECTED when a retained container outlives its session, and it runs before the StopImpl/DeleteImpl catch boundaries. The client SDK's catch cannot provide the server's HRESULT conversion. Could Stop and Delete include the session/context setup inside CATCH_RETURN, and extend ContainerAndProcessOutliveSession to check both methods?

Summary of the Pull Request
Sync merge with master into feature/compose
PR Checklist
Detailed Description of the Pull Request / Additional comments
Nothing new here, just merging in master.
Validation Steps Performed