Add polyglot ACA custom domain support#15811
Merged
sebastienros merged 2 commits intomainfrom Apr 3, 2026
Merged
Conversation
Add the ATS export for ConfigureCustomDomain and update the Azure AppContainers Java, Python, and TypeScript validation AppHosts to exercise the generated callback API. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15811Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15811" |
eerhardt
reviewed
Apr 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR exposes the existing Azure Container Apps ConfigureCustomDomain customization API to polyglot AppHosts via ATS exports, and updates the polyglot validation AppHosts to exercise the generated API surface.
Changes:
- Export
ContainerAppExtensions.ConfigureCustomDomainto ATS so it can be invoked onContainerAppinside polyglot publish callbacks. - Update TypeScript, Java, and Python Azure AppContainers validation AppHosts to call the generated
configureCustomDomainAPI. - Refresh XML documentation by removing stale “polyglot unsupported” wording and fixing a minor typo.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/PolyglotAppHosts/Aspire.Hosting.Azure.AppContainers/TypeScript/apphost.ts | Adds parameter resources and calls app.configureCustomDomain(...) in the ACA publish callback. |
| tests/PolyglotAppHosts/Aspire.Hosting.Azure.AppContainers/Python/apphost.py | Adds parameter resources and calls app.configure_custom_domain(...) in the ACA publish callback. |
| tests/PolyglotAppHosts/Aspire.Hosting.Azure.AppContainers/Java/AppHost.java | Adds parameter resources and calls app.configureCustomDomain(...) in the ACA publish callback. |
| src/Aspire.Hosting.Azure.AppContainers/ContainerAppExtensions.cs | Switches from AspireExportIgnore to AspireExport for ConfigureCustomDomain and updates remarks text. |
Remove the language-specific XML doc note and fix the Python Azure AppContainers validation fixture to keep exercising the Log Analytics overload. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🎬 CLI E2E Test Recordings — 55 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #23920194210 |
eerhardt
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15706
ConfigureCustomDomainalready exists for Azure Container Apps in C#, but the polyglot AppHost surfaces did not expose it. This change exports the existing API through ATS so the generated callback surface can configure custom domains from polyglot AppHosts onContainerApp, and updates the Azure AppContainers Java, Python, and TypeScript validation AppHosts to exercise that generated API.This stays narrowly scoped to the existing callback shape rather than introducing a new free-function model, and it removes the stale XML doc text that said polyglot AppHosts were unsupported. No new runtime dependencies were added.
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: