Envs for images #291
Merged
Envs for images #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
MarcCote
force-pushed
the
envs_for_images
branch
from
2a0f4d1 to
c80e6d8
Compare
MarcCote
approved these changes
Dec 2, 2025
Collaborator
MarcCote
left a comment
MarcCote
left a comment
There was a problem hiding this comment.
I think we are ready for a final review.
matheper
reviewed
Dec 2, 2025
| self._task_name = base_image | ||
| self.setup_commands = setup_commands or [] | ||
| self.namespace = namespace | ||
| self.namespace = namespace or os.environ.get("K8S_NAMESPACE", "default") |
Collaborator
There was a problem hiding this comment.
Can you document these env vars in the readme?
Collaborator
|
run.py is broken. apparently we don't have integration tests for it. Will fix and add some. |
Collaborator
|
@copilot summarize what this PR is about. |
Closed
Contributor
|
@xingdi-eric-yuan I've opened a new pull request, #302, to work on those changes. Once the pull request is ready, I'll request review from you. |
| from debug_gym.gym.terminals.terminal import Terminal | ||
|
|
||
|
|
||
| class LocalEnv(RepoEnv): |
Collaborator
There was a problem hiding this comment.
Could be confusing if local env can be use non-local terminals
Collaborator
There was a problem hiding this comment.
Open to suggestion to rename it. LocalDirEnv?
Collaborator
There was a problem hiding this comment.
BaseEnv and RepoEnv sounds good
MarcCote
force-pushed
the
envs_for_images
branch
2 times, most recently
from
a765ee7 to
4c9dbfa
Compare
MarcCote
force-pushed
the
envs_for_images
branch
from
4c9dbfa to
22121f3
Compare
MarcCote
force-pushed
the
envs_for_images
branch
from
a4a49c1 to
a55cd11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also removes dependency on swesmith: #292