Merged
Conversation
Collaborator
Author
|
Ah, I see you are supporting |
Collaborator
Author
|
I propose dropping support for lower versions. But I am happy to also write some workaround code for the |
Collaborator
|
thanks a lot! I would actually prefer to keep the current minimum since I am using 0.4.29 in some project. |
ae-foster
force-pushed
the
ae-foster/fix-jax-version-pallas
branch
from
92b62bc to
8ae452e
Compare
Collaborator
Author
|
Just pushed a fix that doesn't change the versions :) Hopefully we can remove some of these hacks at a later stage, but everything is now working across all supported versions-yay |
ae-foster
force-pushed
the
ae-foster/fix-jax-version-pallas
branch
from
8ae452e to
2634e24
Compare
n-gao
approved these changes
May 28, 2025
Collaborator
n-gao
left a comment
n-gao
left a comment
There was a problem hiding this comment.
Thanks a lot, looks great! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33
The fix for the latest version of jax is actually already available in
jax==0.4.34, which I believe is the lowest version we support. So we can simply switch to the updated API across all versions. Tested on0.4.34and everything works