Skip to content

fix: ignored commands were still loading #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpendery merged 2 commits into from
Mar 22, 2026
Merged

fix: ignored commands were still loading #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e758f5
fix: ignored commands were still loading
cpendery Mar 22, 2026
d988b78
fix: remove testgp
cpendery Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/runtime/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { specResourcesPath } from "../utils/constants.js";
// eslint-disable-next-line @typescript-eslint/no-explicit-any -- recursive type, setting as any
const specSet: any = {};
const ignoredSpecs = ["gcloud", "az", "aws"];
const speclist = figSpecList.filter((spec: string) => !ignoredSpecs.some((name) => spec.startsWith(name + "/")));
const speclist = figSpecList.filter((spec: string) => !ignoredSpecs.some((name) => spec === name || spec.startsWith(name + "/")));
const versionedSpeclist = figVersionedSpeclist.filter((spec: string) => !ignoredSpecs.some((name) => spec.startsWith(name)));

function loadSpecsSet(speclist: string[], versionedSpeclist: string[], specsPath: string) {
Expand Down
25 changes: 0 additions & 25 deletions src/tests/runtime/__snapshots__/runtime.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,31 +529,6 @@ exports[`parseCommand generatorUsingPartialInput 1`] = `
}
`;

exports[`parseCommand loadSpec 1`] = `
{
"activeToken": {
"complete": false,
"isOption": false,
"token": "add",
"tokenLength": 3,
},
"suggestions": [
{
"allNames": [
"add-tags-to-certificate",
],
"description": "Adds one or more tags to an ACM certificate. Tags are labels that you can use to identify and organize your Amazon Web Services resources. Each tag consists of a key and an optional value. You specify the certificate on input by its Amazon Resource Name (ARN). You specify the tag by using a key-value pair. You can apply a tag to just one certificate if you want to identify a specific characteristic of that certificate, or you can apply the same tag to multiple certificates if you want to filter for a common relationship among those certificates. Similarly, you can apply the same tag to multiple resources if you want to specify a relationship among those resources. For example, you can add the same tag to an ACM certificate and an Elastic Load Balancing load balancer to indicate that they are both used by the same website. For more information, see Tagging ACM certificates. To remove one or more tags, use the RemoveTagsFromCertificate action. To view all of the tags that have been applied to the certificate, use the ListTagsForCertificate action",
"hidden": undefined,
"icon": "📦",
"insertValue": undefined,
"name": "add-tags-to-certificate",
"priority": 50,
"type": undefined,
},
],
}
`;

exports[`parseCommand noArgsArgumentGiven 1`] = `
{
"activeToken": undefined,
Expand Down
4 changes: 2 additions & 2 deletions src/tests/runtime/runtime.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ const testData = [
{ name: "providedArgDescription", command: "act completion bash -a " },
{ name: "completedOptionWithArg", command: "act completion bash -a 'actor' " },
{ name: "command", command: "sudo git sta" },
{ name: "nestedNonCommands", command: "az az ", skip: true }, // TODO: fix skipped test
{ name: "loadSpec", command: "aws acm add" },
{ name: "nestedNonCommands", command: "az az ", skip: true }, // no longer supported
{ name: "loadSpec", command: "aws acm add", skip: true }, // no longer loaded
{ name: "noArgsArgumentGiven", command: "gcc lab ", maxSuggestions: 3 },
{ name: "generatorUsingPartialInput", command: "dotnet add package Microsoft.Azure.WebJobs.Cor", maxSuggestions: 1 },
{ name: "pathSuggestion", command: "source she" },
Expand Down
Loading