Use physical pointer abstraction in LVBS#817
Open
sangho2 wants to merge 16 commits into
Open
Conversation
29c61b5 to
e42c3a0
Compare
8b9b1f7 to
3a833f2
Compare
wdcui
reviewed
May 15, 2026
|
|
||
| /// Provider for physical page mapping operations used by physical pointers. | ||
| pub trait PhysMapProvider<const ALIGN: usize> { | ||
| fn validate_unowned(_pages: &PhysPageAddrArray<ALIGN>) -> Result<(), PhysPointerError> { |
Member
There was a problem hiding this comment.
Add a comment for this trait method?
Contributor
Author
There was a problem hiding this comment.
This is just a proxy. Let me add a link to
litebox/litebox_common_linux/src/vmap.rs
Line 53 in ca99ea2
wdcui
reviewed
May 15, 2026
| use crate::mshv::ringbuffer::set_ringbuffer; | ||
| use crate::{ | ||
| debug_serial_println, | ||
| Vtl0PhysConstPtr, Vtl0PhysMutPtr, debug_serial_println, |
Member
There was a problem hiding this comment.
We use both Vtl0 and NormalWorld?
Contributor
Author
There was a problem hiding this comment.
Yes. It depends on context LVBS/HVCI/HEKI vs OP-TEE.
added 13 commits
May 21, 2026 20:23
added 2 commits
May 21, 2026 20:27
24fcce1 to
3dc8650
Compare
c6fd071 to
24e1d87
Compare
|
🤖 SemverChecks 🤖 Click for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lets LVBS use physical pointer abstraction to access VTL0 memory. This is equivalent to the OP-TEE shim's normal-world memory access such that it is not only safer than the legacy memory copy functions but also supporting non-contiguous physical pages. This PR and physical address range lock (next PR) will enable memory-safe VTL0 memory access (i.e., drop
unsafefrom read/write methods).