Migrate AKS to recordings #1384
Merged
+42
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
requested review from
a team,
feiskyer and
gossion
as code owners
alzimmermsft
requested review from
JasonYeMSFT,
fanyang-mono,
joshfree,
msalaman,
sandeep-sen,
vukelich and
weshaggard
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates Azure Kubernetes Service (AKS) live tests to use recorded test infrastructure, enabling tests to be run against pre-recorded HTTP interactions instead of requiring live Azure resources.
Key Changes
- Converted test classes from
CommandTestsBasetoRecordedCommandTestsBasewith test proxy fixture support - Implemented variable registration for dynamic values (cluster names, resource groups, node pool names) to support playback mode
- Added
assets.jsonconfiguration file to track recorded test assets in the Azure SDK assets repository
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Aks/tests/Azure.Mcp.Tools.Aks.LiveTests/assets.json | Added assets configuration file for managing recorded test data with Azure SDK assets repository |
| tools/Azure.Mcp.Tools.Aks/tests/Azure.Mcp.Tools.Aks.LiveTests/NodepoolGetCommandTests.cs | Migrated to recorded tests with variable registration and playback-aware assertions |
| tools/Azure.Mcp.Tools.Aks/tests/Azure.Mcp.Tools.Aks.LiveTests/NodepoolCommandTests.cs | Updated to use RecordedCommandTestsBase and registered variables for cluster identifiers |
| tools/Azure.Mcp.Tools.Aks/tests/Azure.Mcp.Tools.Aks.LiveTests/AksCommandTests.cs | Converted to recorded tests with property assertions and playback mode handling |
tools/Azure.Mcp.Tools.Aks/tests/Azure.Mcp.Tools.Aks.LiveTests/AksCommandTests.cs
Outdated
Show resolved
Hide resolved
scbedd
approved these changes
Dec 16, 2025
Contributor
scbedd
left a comment
scbedd
left a comment
There was a problem hiding this comment.
Tiny formatting issue is blocking you. LMK when I can approve again.
feiskyer
approved these changes
Dec 17, 2025
Contributor
feiskyer
left a comment
feiskyer
left a comment
There was a problem hiding this comment.
OK, this is for tests. please fix the test failures
scbedd
approved these changes
Dec 18, 2025
github-project-automation
bot
moved this from Untriaged
to In Progress
in Azure MCP Server
ankushbindlish2
added a commit
that referenced
this pull request
Dec 19, 2025
* Fix versions in Fabric changelog and add debug text to script (#1391) * Remove unnecessary build targets and resources (#1375) * Move azure icon to images folder * Remove duplicate resources and unnecessary build targets * Remove unnecessary reference to eng/dnx from pack-nuget * Prevent HashTable.Count from affecting result count check (#1397) * Migrate Authorization to recordings (#1399) * Fix execution of parallel testclasses within testassembly (#1393) * assets.json longer optional * changes to prevent multiple proxy instances from restoring simultaneously * Fabric MCP: Add OneLake namespace to VSCode options (#1398) * Fabric MCP: Add OneLake namespace to VSCode options * Update descriptions * Increment versions and update CHANGELOGs after release (#1371) Updated CHANGELOGs and project version after release * Migrate `marketplace` to recordings (#1396) * simplify the client creation a bit, remove unnecessary test parts, as the newing that is being exercised in the construction of the test isn't actually used for anything. the product commands ARE though * Migrate AKS to recordings (#1384) * Migrate AKS to recordings * Fix linting, synchronize starting proxy * Revert lock change --------- Co-authored-by: Scott Beddall (from Dev Box) <[email protected]> * Migrate Function App to recordings (#1410) --------- Co-authored-by: Patrick Hallisey <[email protected]> Co-authored-by: Alan Zimmer <[email protected]> Co-authored-by: Scott Beddall <[email protected]> Co-authored-by: Amos Hersch <[email protected]> Co-authored-by: vcolin7 <[email protected]> Co-authored-by: Scott Beddall (from Dev Box) <[email protected]>
ankushbindlish2
added a commit
that referenced
this pull request
Dec 19, 2025
* Fix versions in Fabric changelog and add debug text to script (#1391) * Remove unnecessary build targets and resources (#1375) * Move azure icon to images folder * Remove duplicate resources and unnecessary build targets * Remove unnecessary reference to eng/dnx from pack-nuget * Prevent HashTable.Count from affecting result count check (#1397) * Migrate Authorization to recordings (#1399) * Fix execution of parallel testclasses within testassembly (#1393) * assets.json longer optional * changes to prevent multiple proxy instances from restoring simultaneously * Fabric MCP: Add OneLake namespace to VSCode options (#1398) * Fabric MCP: Add OneLake namespace to VSCode options * Update descriptions * Increment versions and update CHANGELOGs after release (#1371) Updated CHANGELOGs and project version after release * Migrate `marketplace` to recordings (#1396) * simplify the client creation a bit, remove unnecessary test parts, as the newing that is being exercised in the construction of the test isn't actually used for anything. the product commands ARE though * Migrate AKS to recordings (#1384) * Migrate AKS to recordings * Fix linting, synchronize starting proxy * Revert lock change --------- Co-authored-by: Scott Beddall (from Dev Box) <[email protected]> * Migrate Function App to recordings (#1410) --------- Co-authored-by: Patrick Hallisey <[email protected]> Co-authored-by: Alan Zimmer <[email protected]> Co-authored-by: Scott Beddall <[email protected]> Co-authored-by: Amos Hersch <[email protected]> Co-authored-by: vcolin7 <[email protected]> Co-authored-by: Scott Beddall (from Dev Box) <[email protected]>
ankushbindlish2
added a commit
that referenced
this pull request
Dec 19, 2025
* Fix versions in Fabric changelog and add debug text to script (#1391) * Remove unnecessary build targets and resources (#1375) * Move azure icon to images folder * Remove duplicate resources and unnecessary build targets * Remove unnecessary reference to eng/dnx from pack-nuget * Prevent HashTable.Count from affecting result count check (#1397) * Migrate Authorization to recordings (#1399) * Fix execution of parallel testclasses within testassembly (#1393) * assets.json longer optional * changes to prevent multiple proxy instances from restoring simultaneously * Fabric MCP: Add OneLake namespace to VSCode options (#1398) * Fabric MCP: Add OneLake namespace to VSCode options * Update descriptions * Increment versions and update CHANGELOGs after release (#1371) Updated CHANGELOGs and project version after release * Migrate `marketplace` to recordings (#1396) * simplify the client creation a bit, remove unnecessary test parts, as the newing that is being exercised in the construction of the test isn't actually used for anything. the product commands ARE though * Migrate AKS to recordings (#1384) * Migrate AKS to recordings * Fix linting, synchronize starting proxy * Revert lock change --------- Co-authored-by: Scott Beddall (from Dev Box) <[email protected]> * Migrate Function App to recordings (#1410) --------- Co-authored-by: Patrick Hallisey <[email protected]> Co-authored-by: Alan Zimmer <[email protected]> Co-authored-by: Scott Beddall <[email protected]> Co-authored-by: Amos Hersch <[email protected]> Co-authored-by: vcolin7 <[email protected]> Co-authored-by: Scott Beddall (from Dev Box) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates Azure Kubernetes Service to recorded live tests.
GitHub issue number?
Resolves #1275
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.json/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline