Migrate marketplace to recordings
#1396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the newing that is being exercised in the construction of the test isn't actually used for anything. the product commands ARE though
…ultiple-test-classes issue.
scbedd
requested review from
JasonYeMSFT,
hallipr,
joshfree,
msalaman,
sandeep-sen,
vukelich and
weshaggard
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the Marketplace tool's live tests to use the recorded test infrastructure, enabling test playback without requiring live Azure resources.
Key Changes
- Converted test classes to inherit from
RecordedCommandTestsBaseinstead ofCommandTestsBase - Added test recording infrastructure via
assets.jsonconfiguration file - Updated
MarketplaceServiceto properly use HttpClient through the Azure Core pipeline for recording support
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tools/Azure.Mcp.Tools.Marketplace/tests/Azure.Mcp.Tools.Marketplace.LiveTests/assets.json |
Added assets.json configuration file for test recording infrastructure with appropriate TagPrefix and repository settings |
tools/Azure.Mcp.Tools.Marketplace/tests/Azure.Mcp.Tools.Marketplace.LiveTests/ProductListCommandTests.cs |
Refactored test class to use RecordedCommandTestsBase with primary constructor, removed manual service instantiation, made class sealed |
tools/Azure.Mcp.Tools.Marketplace/tests/Azure.Mcp.Tools.Marketplace.LiveTests/ProductGetCommandTests.cs |
Refactored test class to use RecordedCommandTestsBase with primary constructor, removed manual service instantiation, made class sealed |
tools/Azure.Mcp.Tools.Marketplace/src/Services/MarketplaceService.cs |
Updated HTTP request handling to use proper resource disposal patterns with using statements for HttpClient, request, and response objects |
alzimmermsft
approved these changes
Dec 18, 2025
github-project-automation
bot
moved this from Untriaged
to In Progress
in Azure MCP Server
ankushbindlish2
added a commit
that referenced
this pull request
Dec 19, 2025
* Fix versions in Fabric changelog and add debug text to script (#1391) * Remove unnecessary build targets and resources (#1375) * Move azure icon to images folder * Remove duplicate resources and unnecessary build targets * Remove unnecessary reference to eng/dnx from pack-nuget * Prevent HashTable.Count from affecting result count check (#1397) * Migrate Authorization to recordings (#1399) * Fix execution of parallel testclasses within testassembly (#1393) * assets.json longer optional * changes to prevent multiple proxy instances from restoring simultaneously * Fabric MCP: Add OneLake namespace to VSCode options (#1398) * Fabric MCP: Add OneLake namespace to VSCode options * Update descriptions * Increment versions and update CHANGELOGs after release (#1371) Updated CHANGELOGs and project version after release * Migrate `marketplace` to recordings (#1396) * simplify the client creation a bit, remove unnecessary test parts, as the newing that is being exercised in the construction of the test isn't actually used for anything. the product commands ARE though * Migrate AKS to recordings (#1384) * Migrate AKS to recordings * Fix linting, synchronize starting proxy * Revert lock change --------- Co-authored-by: Scott Beddall (from Dev Box) <[email protected]> * Migrate Function App to recordings (#1410) --------- Co-authored-by: Patrick Hallisey <[email protected]> Co-authored-by: Alan Zimmer <[email protected]> Co-authored-by: Scott Beddall <[email protected]> Co-authored-by: Amos Hersch <[email protected]> Co-authored-by: vcolin7 <[email protected]> Co-authored-by: Scott Beddall (from Dev Box) <[email protected]>
ankushbindlish2
added a commit
that referenced
this pull request
Dec 19, 2025
* Fix versions in Fabric changelog and add debug text to script (#1391) * Remove unnecessary build targets and resources (#1375) * Move azure icon to images folder * Remove duplicate resources and unnecessary build targets * Remove unnecessary reference to eng/dnx from pack-nuget * Prevent HashTable.Count from affecting result count check (#1397) * Migrate Authorization to recordings (#1399) * Fix execution of parallel testclasses within testassembly (#1393) * assets.json longer optional * changes to prevent multiple proxy instances from restoring simultaneously * Fabric MCP: Add OneLake namespace to VSCode options (#1398) * Fabric MCP: Add OneLake namespace to VSCode options * Update descriptions * Increment versions and update CHANGELOGs after release (#1371) Updated CHANGELOGs and project version after release * Migrate `marketplace` to recordings (#1396) * simplify the client creation a bit, remove unnecessary test parts, as the newing that is being exercised in the construction of the test isn't actually used for anything. the product commands ARE though * Migrate AKS to recordings (#1384) * Migrate AKS to recordings * Fix linting, synchronize starting proxy * Revert lock change --------- Co-authored-by: Scott Beddall (from Dev Box) <[email protected]> * Migrate Function App to recordings (#1410) --------- Co-authored-by: Patrick Hallisey <[email protected]> Co-authored-by: Alan Zimmer <[email protected]> Co-authored-by: Scott Beddall <[email protected]> Co-authored-by: Amos Hersch <[email protected]> Co-authored-by: vcolin7 <[email protected]> Co-authored-by: Scott Beddall (from Dev Box) <[email protected]>
ankushbindlish2
added a commit
that referenced
this pull request
Dec 19, 2025
* Fix versions in Fabric changelog and add debug text to script (#1391) * Remove unnecessary build targets and resources (#1375) * Move azure icon to images folder * Remove duplicate resources and unnecessary build targets * Remove unnecessary reference to eng/dnx from pack-nuget * Prevent HashTable.Count from affecting result count check (#1397) * Migrate Authorization to recordings (#1399) * Fix execution of parallel testclasses within testassembly (#1393) * assets.json longer optional * changes to prevent multiple proxy instances from restoring simultaneously * Fabric MCP: Add OneLake namespace to VSCode options (#1398) * Fabric MCP: Add OneLake namespace to VSCode options * Update descriptions * Increment versions and update CHANGELOGs after release (#1371) Updated CHANGELOGs and project version after release * Migrate `marketplace` to recordings (#1396) * simplify the client creation a bit, remove unnecessary test parts, as the newing that is being exercised in the construction of the test isn't actually used for anything. the product commands ARE though * Migrate AKS to recordings (#1384) * Migrate AKS to recordings * Fix linting, synchronize starting proxy * Revert lock change --------- Co-authored-by: Scott Beddall (from Dev Box) <[email protected]> * Migrate Function App to recordings (#1410) --------- Co-authored-by: Patrick Hallisey <[email protected]> Co-authored-by: Alan Zimmer <[email protected]> Co-authored-by: Scott Beddall <[email protected]> Co-authored-by: Amos Hersch <[email protected]> Co-authored-by: vcolin7 <[email protected]> Co-authored-by: Scott Beddall (from Dev Box) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1292