Improve Python's tokenizer for numeric literals #5084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves Python's tokenizer for numeric literals with respect to several aspects: - Support underscores between digits and after prefixes (fixes microsoft#4745) - Support octal and binary literals - Support case-insensitive prefixes for hex/octal/binary literals - Recognize a possible leading minus sign as a separate token, instead of mistakenly treating it as part of the numeric literal Reference: https://docs.python.org/3/reference/lexical_analysis.html#numeric-literals Add tests to cover several of the above cases and their combinations.
Author
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves Python's tokenizer for numeric literals with respect to several aspects:
Reference: https://docs.python.org/3/reference/lexical_analysis.html#numeric-literals
Add tests to cover several of the above cases and their combinations.
P.S.: I ran the tests with
v0.52.0, as they have been (mistakenly? temporarily?) removed in e56ad4b.