chore(bidi): add support for network.setExtraHeaders #38079
Conversation
hbenl
force-pushed
the
set-extra-headers
branch
from
4026de4 to
eecb28a
Compare
Test results for "MCP"2588 passed, 116 skipped Merge workflow run. |
Test results for "tests 1"1 failed 4 flaky40317 passed, 789 skipped Merge workflow run. |
| async doUpdateExtraHTTPHeaders(): Promise<void> { | ||
| let allHeaders = this._options.extraHTTPHeaders || []; | ||
| if (this._options.locale) | ||
| allHeaders = network.mergeHeaders([allHeaders, network.singleHeader('Accept-Language', this._options.locale)]); |
There was a problem hiding this comment.
I see that we set this custom header on the client end in both Firefox and WebKit in Playwright, but it feels like cutting corners a bit and I wonder if it'd make more sense to make it a part of the browser implementation of the emulation.setLocaleOverride command (similar how it is done in Chromium)?
There was a problem hiding this comment.
I wonder if it'd make more sense to make it a part of the browser implementation of the emulation.setLocaleOverride command (similar how it is done in Chromium)?
That's the plan. I will remove this logic when the spec and Firefox' implementation have been updated.
2 participants
Fixes #38060 and the following tests:
tests/library/browsercontext-locale.spec.ts:tests/library/browsercontext-set-extra-http-headers.spec.ts:tests/library/defaultbrowsercontext-2.spec.ts:tests/library/popup.spec.ts:tests/page/page-route.spec.ts:tests/page/page-set-extra-http-headers.spec.ts: