Fix full release stage conditions - #11638
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0ff3bd87-e2ce-4abb-9b7e-c1095364e159
Collaborator
|
🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR. |
Rich Chiodo (rchiodo)
approved these changes
Aug 14, 2026
Rich Chiodo (rchiodo)
left a comment
Rich Chiodo (rchiodo)
left a comment
Collaborator
There was a problem hiding this comment.
Approved via Review Center.
Rich Chiodo (rchiodo)
added
the
review-auto:approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix full Pyright release runs skipping all production stages after npm artifact validation.
RecoverNpmArtifactis intentionally skipped infullmode. The downstream stages usedsucceeded(), which evaluated false because that skipped stage was a transitive dependency throughValidateNpm. Check each stage's explicit prerequisite results instead.Validation
Pyright-Releasecondition-only run passed infullmode: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=14977419&view=resultsRecoverNpmArtifactskipped, whileCreateRelease,WaitForValidation,PublishToMarketplace, andPublishToNpmall succeeded.This unblocks recovery of the tagged but unpublished
1.1.413release.