Skip to content

Conversation

@minestarks
Copy link
Member

Enables source code links for grouped operations, just as with simple gates.

image

@minestarks minestarks changed the title circuit diagrams: show source code links for grouped operations Circuit diagrams: Show source code links for grouped operations Dec 30, 2025
@minestarks minestarks marked this pull request as ready for review December 30, 2025 21:32
@minestarks minestarks force-pushed the minestarks/source-links-for-groups branch from af6be5e to d738be7 Compare December 31, 2025 15:47
@ScottCarda-MS
Copy link
Contributor

I noticed two things while playing around with this:

  1. If I collapse all of a circuit to the Main operation, that Main box is not clickable despite the fact that there is a Main operation that it could navigate the user to.
  2. The expand/collapse state of a group is not preserved when collapsing a surrounding group. If A calls B, there will be a group A that, when expanded will show a collapsed group B. If I then expand the group B and collapse and re-expand the surrounding group A, B does not remember that it was expanded and shows as collapsed instead.

@minestarks
Copy link
Member Author

@ScottCarda-MS

  1. The expand/collapse state of a group is not preserved when collapsing a surrounding group. If A calls B, there will be a group A that, when expanded will show a collapsed group B. If I then expand the group B and collapse and re-expand the surrounding group A, B does not remember that it was expanded and shows as collapsed instead.

The expand/collapse behavior is a bit of a mess. Frankly I've had trouble figuring out what the "correct" behavior even should be - from your description, this sounds normal to me, but maybe it feels awkward in practice. Do you happen to know if what you're seeing is new in this PR, or is it the same in main? (I can check if you don't know).

@ScottCarda-MS
Copy link
Contributor

ScottCarda-MS commented Jan 7, 2026

The expand/collapse behavior is a bit of a mess. Frankly I've had trouble figuring out what the "correct" behavior even should be - from your description, this sounds normal to me, but maybe it feels awkward in practice. Do you happen to know if what you're seeing is new in this PR, or is it the same in main? (I can check if you don't know).

The behavior didn't change with this PR, so it is consistent with what is in main.

@minestarks
Copy link
Member Author

@ScottCarda-MS I have some expand/collapse behavior refinement in the works - stay tuned!

@minestarks minestarks added this pull request to the merge queue Jan 7, 2026
Merged via the queue into main with commit 1267a0d Jan 7, 2026
18 checks passed
@minestarks minestarks deleted the minestarks/source-links-for-groups branch January 7, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants