-
Notifications
You must be signed in to change notification settings - Fork 83
CI/CD - Fix Image build for cuda11.1.1 #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #771 +/- ##
=======================================
Coverage 85.69% 85.70%
=======================================
Files 102 102
Lines 7699 7703 +4
=======================================
+ Hits 6598 6602 +4
Misses 1101 1101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
abuccts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip (Python 3.8) cannot find a pre-built wheel for the latest wandb release (v0.23.1)
According to wandb v0.23.1, it's compatible with py3.8. Maybe you need to upgrade pip/wheel?
However, the build fails because the image does not have Go installed, which is required for building wandb from source.
Why not just add an apt-get install -y golang?
Added build-essential packages to the CUDA 11.1.1 Dockerfile to enable building wandb. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abuccts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the title and descriptions accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
**Description** - Deprecated API arguments, 'interpolation', when numpy >v1.22.0. And it was removed since v2.4.0. - Pandas to_exel() failed in unit test. Solution - Update the NumPy API usage to support NumPy 1.22.0+ while maintaining backward compatibility with earlier versions. - Fixed the pandas to_excel() API compatibility issue. In newer versions of pandas (2.0+), the 'sheet_name' parameter must be passed as a keyword argument rather than a positional argument --------- Co-authored-by: Hongtao Zhang <hongtaozhang@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
/azp run CodeQL |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/retest |
Description
Solution