history - indicate if a recently opened folder/workspace is opened as window #276351
+101
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a getWindows method to the IHostService interface to retrieve a list of opened windows, with support for optionally including auxiliary windows. The implementation distinguishes between main windows (which have workspace information) and auxiliary windows (which have parent window references).
Key changes:
- Added
getWindowsmethod toIHostServiceinterface with overloads based onincludeAuxiliaryWindowsoption - Implemented the method in both browser and native (Electron) host services
- Updated the "Open Recent" action to show an indicator for workspaces/folders currently opened in windows
- Added visual styling to differentiate opened workspace entries in the recently opened picker
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/services/host/browser/host.ts | Added interface method signatures for getWindows with overloads |
| src/vs/workbench/services/host/browser/browserHostService.ts | Implemented getWindows method for browser environment to collect main and auxiliary windows |
| src/vs/workbench/services/host/electron-browser/nativeHostService.ts | Implemented getWindows method for Electron environment delegating to native host service |
| src/vs/workbench/browser/actions/windowActions.ts | Updated "Open Recent" action to fetch and display windows with opened indicator |
| src/vs/workbench/browser/actions/media/actions.css | Added CSS rule to show close icon on hover for opened workspace entries |
| src/vs/workbench/test/browser/workbenchTestServices.ts | Added stub implementation of getWindows to test service |
alexdima
approved these changes
Nov 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.