Repository navigation
Explain which foreground check refused a drag #1385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alexandre Zollinger Chohfi (azchohfi)
wants to merge
3
commits into
main
Choose a base branch
from
azchohfi-guarded-input-diagnostics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+312
−18
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
src/winapp-CLI/WinApp.UIAutomation/Input/ForegroundCheckSnapshot.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| // Copyright (c) Microsoft Corporation and Contributors. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| namespace Microsoft.Windows.SDK.BuildTools.WinApp.UIAutomation; | ||
|
|
||
| /// <summary>Retained observations from a rejected foreground check, not a later foreground query.</summary> | ||
| /// <remarks> | ||
| /// The comparison and desktop classification use separate foreground reads. Process IDs, and the root | ||
| /// when it was not compared, are queried afterward at <paramref name="MetadataAtUtc"/>. These observations | ||
| /// are not atomic; a zero process ID means the window's process could not be determined. | ||
| /// </remarks> | ||
| /// <param name="ComparedAtUtc">UTC time immediately before the foreground comparison.</param> | ||
| /// <param name="TargetHwnd">Window the check was asked to protect.</param> | ||
| /// <param name="RootHwnd">Target's top-level root, or zero when unavailable.</param> | ||
| /// <param name="RootWasCompared">Whether the root came from the comparison rather than the metadata read.</param> | ||
| /// <param name="ForegroundHwnd">Foreground window observed by the comparison, or zero.</param> | ||
| /// <param name="ClassifiedAtUtc">UTC time immediately before the desktop-classification foreground read.</param> | ||
| /// <param name="ClassificationForegroundHwnd">Foreground window observed by the second read, or zero.</param> | ||
| /// <param name="MetadataAtUtc">UTC time immediately before querying diagnostic window ownership.</param> | ||
| /// <param name="TargetProcessId">Process owning the target at the metadata read.</param> | ||
| /// <param name="RootProcessId">Process owning the root at the metadata read.</param> | ||
| /// <param name="ForegroundProcessId">Process owning the comparison's foreground handle at the metadata read.</param> | ||
| /// <param name="ClassificationForegroundProcessId">Process owning the second read's handle at the metadata read.</param> | ||
| public sealed record ForegroundCheckSnapshot( | ||
| DateTimeOffset ComparedAtUtc, | ||
| long TargetHwnd, | ||
| long RootHwnd, | ||
| bool RootWasCompared, | ||
| long ForegroundHwnd, | ||
| DateTimeOffset ClassifiedAtUtc, | ||
| long ClassificationForegroundHwnd, | ||
| DateTimeOffset MetadataAtUtc, | ||
| uint TargetProcessId, | ||
| uint RootProcessId, | ||
| uint ForegroundProcessId, | ||
| uint ClassificationForegroundProcessId); | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.