Fix arches.rdl roundtrip: resolve enum variant names and panic on missing metadata#4071
Closed
Fix arches.rdl roundtrip: resolve enum variant names and panic on missing metadata#4071
Conversation
…missing enum types Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/14606d4f-3629-48fe-8ab3-eda298f981b9
Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/2137ab30-b06b-4fa0-a7e0-13f12d34d609
Copilot created this pull request from a session on behalf of
kennykerr
March 25, 2026 15:50
View session
Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/ced684b2-1791-49d6-b65f-e33043c3af84
…_panic] form Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/3c9f1e17-41bf-4df7-8d02-0faef554cd11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_to_file→Result<(), Error>(with I/O error details in message)write_enum_value→Result<TokenStream, Error>extract_guid_from_attribute→Result<(u32, u16, u16, [u8; 8]), Error>write_const_guid/write_const/write_const_value→Result<TokenStream, Error>write_custom_attributes_except/write_custom_attributes→Result<Vec<TokenStream>, Error>write_params→Result<Vec<TokenStream>, Error>interface_guid_is_derived/delegate_guid_is_derived→Result<bool, Error>write_type_def/write_type_def_items/write_items→ Resultwrite()to propagate errors with?writer_missing_enum_reference_panicstest back to#[should_panic]form (roundtrip/arches testing to be handled separately)cargo test -p test_rdl --test panic— all 45 tests pass