Conversation
… tests Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/f49d540b-9088-48b7-9277-e1df74982476 Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
…() in tests Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/f49d540b-9088-48b7-9277-e1df74982476 Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
… 0) boilerplate Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/f23c82e3-0137-49d3-a52f-5e6e6c9266d9 Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
kennykerr
April 5, 2026 02:21
View session
Collaborator
|
@copilot fix build errors |
…path (Windows CI fix) Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/bbedb6e3-feca-4013-b120-26dcf5eb2312 Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Contributor
Author
Fixed in 8de931b. The two failing tests ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The writer accumulated ~15 repetitions of
Error::new(&format!("…"), "", 0, 0)— all writer errors have no source position (empty file, line 0, col 0), making the three trailing arguments pure noise.Changes
writer/mod.rs— definesmacro_rules! writer_errthat wrapsError::new(&format!(…), "", 0, 0), then re-exports it withpub(crate) use writer_errso all sub-modules pick it up via their existinguse super::*callback.rs,class.rs,delegate.rs,enum.rs,fn.rs,mod.rs— replace all 15 bareError::new(…, "", 0, 0)call sites withwriter_err!(…); the twoError::newcalls with non-empty file names are intentionally left untouchedtests/writer_errors.rs— fix two I/O failure tests that used/nonexistent/deeply/nested/…as an "unwritable" path; on Windows that resolves toC:\nonexistent\…which the CI runner can write to. Tests now create a regular temp file as a blocker and attempt to use it as a directory component —create_dir_allcannot replace a file with a directory on any platform.Before:
After: