Fix for Loading Invalid Manifests#538
Open
The-Running-Dev wants to merge 2 commits intomicrosoft:mainfrom
Open
Fix for Loading Invalid Manifests#538The-Running-Dev wants to merge 2 commits intomicrosoft:mainfrom
The-Running-Dev wants to merge 2 commits intomicrosoft:mainfrom
Conversation
- Added new GetManifest, wrapped in try/catch. - Updated ParseExeInstallerType to use GetManifest
The-Running-Dev
requested review from
a team,
ryfu-msft and
yao-msft
and removed request for
a team
Contributor
|
@The-Running-Dev, do you have an example installer that I can use to try out this fix? |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
Yes I do, try the XYplorer package (CologneCodeCompany.XYplorer). That package is the reason this fix exists. |
|
I feel the correct fix will be to look into why ManifestResource failed on specific manifest and fix the ManifestResource code instead of loading with XmlDocument unchecked and ignore all exceptions. (i.e. we need to look into CologneCodeCompany.XYplorer) |
guerrerosilvana
approved these changes
Dec 26, 2024
Teri68
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new GetManifest, wrapped in try/catch.
Updated ParseExeInstallerType to use GetManifest
Have you signed the Contributor License Agreement?
Are you working against an Issue?
Microsoft Reviewers: Open in CodeFlow