-
Notifications
You must be signed in to change notification settings - Fork 120
35006- Add tests for PDF labeling support in SharePoint Online #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds a new assessment test (Test-Assessment.35006) for validating PDF labeling support in SharePoint Online environments. The test checks whether the EnableSensitivityLabelforPDF setting is enabled in SharePoint tenant configuration.
Key changes:
- New assessment function that queries SharePoint tenant settings for PDF labeling support
- Documentation describing the feature and remediation steps
- Unit tests covering pass, fail, and error scenarios
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/powershell/tests/Test-Assessment.35006.ps1 | Implements the main assessment logic to check if PDF labeling is enabled in SharePoint Online |
| src/powershell/tests/Test-Assessment.35006.md | Provides documentation and remediation steps for enabling PDF labeling support |
| code-tests/test-assessments/Test-Assessment.35006.Tests.ps1 | Contains unit tests for the assessment function covering enabled, disabled, and error scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add a null check ensuring that `$spoTenant` cannot be null Co-authored-by: Copilot <[email protected]>
Information --> information Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
for --> For Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SagarSathe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix https://github.com/microsoft/ztspecs/issues/56