feat: implement microvm.vms.*.extraModules
#432
+21
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 16, 2025 13:36
Adds an `extraModules` option for `microvm.vms`, allowing users to pass in a list of NixOS Modules that will be merged into the `config` option specified in `microvm.vms`. This enables fully-declarative MicroVM setups to use existing NixOS Modules from other projects.
ajaxbits
commented
Nov 16, 2025
| }; | ||
|
|
||
| extraModules = mkOption { | ||
| type = types.listOf types.deferredModule; |
Author
There was a problem hiding this comment.
Seeking feedback on the typing of this option. deferredModule seemed correct, but I am not a SME on module definitions like these.
Member
There was a problem hiding this comment.
Author
There was a problem hiding this comment.
Nice find -- I could totally see that being the way to go. I'll let astro weigh in if they have an opinion before I change anything
ajaxbits
changed the title
ajaxbits
changed the title
microvm.vms.*.extraModules
Copilot finished reviewing on behalf of
SuperSandro2000
November 17, 2025 13:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option at
microvm.vms.*.extraModuleswhich allows users to pass in a list of NixOS Modules that will be merged intomicrovm.vms.*.config, enabling fully-declarative MicroVM setups to use existing NixOS Modules from other projects.This is achieved by passing the
extraModulesoption through as an argument tolib/eval-config.nix.Fixes #197.