Refactor: Modularize page content using JSON#87
Open
Devasy wants to merge 3 commits intomidudev:mainfrom
Open
Conversation
* 👨🏻💻 Update Header.astro Replace url Contacto by mailto:miduga@gmail.com * Update Footer.astro Add id in anchor contact in footer * Fix experience vertical line in light mode * Fix about me image border in light mode * Fix footer container color in dark mode * Update SectionContainer.astro scroll-m-# da un margen con respecto al viewport para cuando se navega a través nav así el nav no queda por encima del title de la section, lo aprendi viendo el codigo fuente de openai.sora que utiliza este estilo de nav. :) * change styles footer * change styles footer * Fix minimal footer styles * SocialPill onhover effect in dark mode * ThemeToggle: el dropdown para cambiar de theme cuando estaba cerrado tenia un opacity-0 por lo que se podian clickear los items dentro del menu, cambie este estilo por un hidden, y en el #themeMenu.open se agrega display: inline para volver a mostrarlo al hacer click * Add license * Upgrade dependencies * Upgrade lock file * Fix footer styles * Some fixes to header styles * Improve new colors to navbar 'Cause the yellow one was bumping into the blur white one * Fix typo in variable name in Experience component * Add TitleSection component * Add TitleSection component to index page * Fixed theme switching bug related to page transitions. * Adding padding to the Footer for mobile resolution * Update Header.astro Al parecer, hay un bug o algo así con Tailwind que impide que el fondo del nav correspondiente se aplique en modo oscuro. Por lo tanto, he modificado un poco el código para evitar que esto ocurra. * "Updated .gitignore to ignore bun.* files and modified LinkButton.astro to add target="_blank" attribute" * add: Light mode support for buttons. --------- Co-authored-by: Dario Espinoza Muñoz <31475869+darioesp@users.noreply.github.com> Co-authored-by: Miguel Ángel Durán <miduga@gmail.com> Co-authored-by: davidchicano <davidchxd19@gmail.com> Co-authored-by: Joseph Vento <114157492+itsJosephV@users.noreply.github.com> Co-authored-by: webzma <wilberledezma51@gmail.com> Co-authored-by: Walter Ortiz <80477967+walterARG2K@users.noreply.github.com> Co-authored-by: Diego Fernández <judifede217@gmail.com> Co-authored-by: bocha13 <ignaciobochatay@gmail.com> Co-authored-by: Carlos Felipe Rivera Güeche <49885608+CarlosRivera4726@users.noreply.github.com> Co-authored-by: Adrian Martin Barcelo <adrian.m.barcelo@gmail.com> Co-authored-by: Amador <amasabcar@outlook.com> Co-authored-by: AbarcaJ <josemiguelabarca8@gmail.com> Co-authored-by: Glitzypanic <jose.fariasdv@gmail.com> Co-authored-by: daniel <110266536+contexto01@users.noreply.github.com> Co-authored-by: tito1984 <txelan84@gmail.com> Co-authored-by: juqndev <ahijadojuancruz@gmail.com>
This commit refactors the portfolio website to load content for the "About Me", "Experience", and "Projects" sections from a central JSON file (`src/data/content.json`). Key changes: - Created `src/data/content.json` to store text, experience data, and project details (including tags and icon references). - Modified `AboutMe.astro`, `Experience.astro`, and `Projects.astro` components to fetch and render data from this JSON file. - Implemented dynamic icon loading in `Projects.astro` by mapping icon string names from JSON to imported Astro icon components. - Updated `README.md` with instructions on how to modify `content.json` to update portfolio content. - Resolved TypeScript errors related to JSON module imports and type checking to ensure a successful build. This change makes it easier for you to update your portfolio content without needing to modify Astro component code directly.
✅ Deploy Preview for animated-churros-60739d ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the portfolio website to load content for the
"About Me", "Experience", and "Projects" sections from a central
JSON file (
src/data/content.json).Key changes:
src/data/content.jsonto store text, experience data,and project details (including tags and icon references).
AboutMe.astro,Experience.astro, andProjects.astrocomponents to fetch and render data from this JSON file.
Projects.astroby mappingicon string names from JSON to imported Astro icon components.
README.mdwith instructions on how to modifycontent.jsonto update portfolio content.type checking to ensure a successful build.
This change makes it easier for you to update your portfolio
content without needing to modify Astro component code directly.