Ignore "session not found" if paranoid is switched on#262
Open
jamesjefferies wants to merge 1 commit into
Open
Ignore "session not found" if paranoid is switched on#262jamesjefferies wants to merge 1 commit into
jamesjefferies wants to merge 1 commit into
Conversation
Owner
|
Thank you for this. Have you investigated what other auth solutions do around this? |
Author
|
@mikker I can't say I have I'm afraid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a bot or script is hitting the user sign in, then the
idparam can be something unsuitable, i.e. not an id in the database. The app then throws anActiveRecord::NotFoundexception.This change alters the behaviour so that if paranoid is switched on, then the app ignores the not found and redirects back to the signin page.
However, I would understand if
a) This should be the default behaviour and ignore the paranoid config
b) Current behaviour is desired!
This is related to issue #241