Skip to content

Conversation

@czs007
Copy link
Collaborator

@czs007 czs007 commented Nov 18, 2025

issue: #44585
pr: #45634

@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file size/XL Denotes a PR that changes 500-999 lines. labels Nov 18, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the dco-passed DCO check passed. label Nov 18, 2025
@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

@mergify mergify bot added the kind/bug Issues or changes related a bug label Nov 18, 2025
@sre-ci-robot sre-ci-robot added do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first do-not-merge/need-milestone generate by v2-label-manager labels Nov 18, 2025
@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[FAILED] PR #45634 not merged

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 11.73913% with 203 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.62%. Comparing base (cb08db0) to head (356ec8c).
⚠️ Report is 251 commits behind head on 2.6.

Files with missing lines Patch % Lines
pkg/util/timestamptz/timestamptz.go 13.08% 164 Missing and 2 partials ⚠️
...tcoord/ddl_callbacks_alter_collection_add_field.go 0.00% 5 Missing and 1 partial ⚠️
internal/proxy/http_req_impl.go 0.00% 4 Missing and 1 partial ⚠️
internal/proxy/service_provider.go 20.00% 3 Missing and 1 partial ⚠️
internal/proxy/validate_util.go 0.00% 3 Missing ⚠️
internal/parser/planparserv2/parser_visitor.go 0.00% 2 Missing ⚠️
internal/proxy/task.go 0.00% 0 Missing and 2 partials ⚠️
internal/proxy/task_database.go 0.00% 0 Missing and 2 partials ⚠️
internal/rootcoord/create_collection_task.go 0.00% 0 Missing and 2 partials ⚠️
internal/util/importutilv2/parquet/field_reader.go 0.00% 2 Missing ⚠️
... and 9 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.6   #45644      +/-   ##
==========================================
- Coverage   76.99%   76.62%   -0.38%     
==========================================
  Files        1700     1856     +156     
  Lines      262533   287687   +25154     
==========================================
+ Hits       202142   220438   +18296     
- Misses      53550    59911    +6361     
- Partials     6841     7338     +497     
Components Coverage Δ
Client 78.03% <65.76%> (-0.11%) ⬇️
Core 83.66% <79.17%> (+1.44%) ⬆️
Go 74.64% <52.39%> (-0.75%) ⬇️
Files with missing lines Coverage Δ
internal/proxy/impl.go 72.97% <ø> (-0.93%) ⬇️
...ernal/rootcoord/ddl_callbacks_create_collection.go 85.81% <100.00%> (ø)
internal/rootcoord/describe_collection_task.go 91.89% <ø> (ø)
internal/rootcoord/root_coord.go 78.81% <ø> (-4.97%) ⬇️
internal/proxy/task_query.go 74.76% <0.00%> (+2.44%) ⬆️
internal/proxy/task_search.go 69.05% <0.00%> (-1.94%) ⬇️
internal/proxy/util.go 77.86% <0.00%> (-4.64%) ⬇️
...coord/ddl_callbacks_alter_collection_properties.go 78.20% <0.00%> (ø)
internal/rootcoord/ddl_callbacks_alter_database.go 71.77% <0.00%> (ø)
...nternal/rootcoord/ddl_callbacks_create_database.go 61.70% <0.00%> (ø)
... and 13 more

... and 614 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Nov 18, 2025
@czs007 czs007 added this to the 2.6.6 milestone Nov 18, 2025
@xiaocai2333
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot added lgtm and removed do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first do-not-merge/need-milestone generate by v2-label-manager labels Nov 19, 2025
@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[SUCCESS] PR #45634 merged to master

Use /refresh-label to update related check and label manually

@sre-ci-robot sre-ci-robot merged commit 442bd23 into milvus-io:2.6 Nov 19, 2025
13 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XL Denotes a PR that changes 500-999 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants