Skip to content

Conversation

@XuanYang-cn
Copy link
Contributor

Remove the log stack when setting isCompacting

@XuanYang-cn
Copy link
Contributor Author

/assign @xiaocai2333

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 18, 2025
@mergify mergify bot added the dco-passed DCO check passed. label Nov 18, 2025
@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

@mergify mergify bot added the kind/enhancement Issues or changes related to enhancement label Nov 18, 2025
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.47%. Comparing base (a3b8bcb) to head (6559d95).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/datanode/compactor/mix_compactor.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #45652      +/-   ##
==========================================
- Coverage   76.56%   76.47%   -0.09%     
==========================================
  Files        1877     1875       -2     
  Lines      293323   292544     -779     
==========================================
- Hits       224572   223735     -837     
- Misses      61341    61375      +34     
- Partials     7410     7434      +24     
Components Coverage Δ
Client 78.17% <ø> (ø)
Core 83.19% <ø> (ø)
Go 74.58% <0.00%> (-0.13%) ⬇️
Files with missing lines Coverage Δ
internal/datanode/compactor/mix_compactor.go 71.08% <0.00%> (-0.21%) ⬇️

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Nov 18, 2025
@xiaocai2333
Copy link
Contributor

/lgtm

@tedxu
Copy link
Contributor

tedxu commented Nov 19, 2025

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedxu, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@XuanYang-cn XuanYang-cn added the manual-pass manually set pass before ci-passed labeled label Nov 19, 2025
@XuanYang-cn
Copy link
Contributor Author

/refresh-label

@zhikunyao zhikunyao added manual-pass manually set pass before ci-passed labeled and removed manual-pass manually set pass before ci-passed labeled labels Nov 19, 2025
@sre-ci-robot sre-ci-robot merged commit 40fdf1e into milvus-io:master Nov 19, 2025
14 of 19 checks passed
@XuanYang-cn XuanYang-cn deleted the tidy-code branch November 19, 2025 07:39
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Nov 19, 2025
Remove the log stack when setting isCompacting

pr: milvus-io#45652

Signed-off-by: yangxuan <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Nov 25, 2025
Remove the log stack when setting isCompacting

pr: #45652

Signed-off-by: yangxuan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants