Skip to content

Conversation

@XuanYang-cn
Copy link
Contributor

See also: #45654

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: XuanYang-cn
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 18, 2025
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Nov 18, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 18, 2025
@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

@mergify
Copy link
Contributor

mergify bot commented Nov 18, 2025

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.48%. Comparing base (aa0870d) to head (4cd2cc6).
⚠️ Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
internal/storage/rw.go 0.00% 2 Missing ⚠️
internal/flushcommon/syncmgr/pack_writer_v2.go 0.00% 1 Missing ⚠️
internal/querynodev2/segments/collection.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #45655       +/-   ##
===========================================
- Coverage   83.19%   76.48%    -6.71%     
===========================================
  Files         521     1875     +1354     
  Lines       81430   292657   +211227     
===========================================
+ Hits        67744   223846   +156102     
- Misses      13686    61376    +47690     
- Partials        0     7435     +7435     
Components Coverage Δ
Client 78.17% <ø> (∅)
Core 83.19% <93.75%> (+<0.01%) ⬆️
Go 74.59% <69.40%> (∅)
Files with missing lines Coverage Δ
internal/util/hookutil/cipher.go 85.93% <100.00%> (ø)
internal/flushcommon/syncmgr/pack_writer_v2.go 74.82% <0.00%> (ø)
internal/querynodev2/segments/collection.go 86.26% <0.00%> (ø)
internal/storage/rw.go 76.23% <0.00%> (ø)

... and 1353 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify
Copy link
Contributor

mergify bot commented Nov 19, 2025

@XuanYang-cn cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/ci-rerun-ut-integration

@mergify
Copy link
Contributor

mergify bot commented Nov 19, 2025

@XuanYang-cn cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@XuanYang-cn
Copy link
Contributor Author

/ci-rerun-ut-integration

@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Nov 21, 2025
@mergify mergify bot added the ci-passed label Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants