Merged
Conversation
…ced-search-form feat(component): advanced search form
fix(component): resolve typechecking issues in scroll-area component
Contributor
|
Caution Review failedPull request was closed or merged during review WalkthroughThis PR introduces a comprehensive MCP (Model Context Protocol) server infrastructure for AI-driven CLI tooling, completely reimplements the Advanced Search Form from a provider-based to a compound-component architecture with filter/action/result subcomponents, applies type-safety fixes across scroll-area implementations, and includes extensive documentation, stories, and test coverage for the new form component. Changes
Sequence DiagramsequenceDiagram
participant Client as CLI Client
participant Server as MCP Server
participant Tool as Tool Handler
participant Exec as Shell/File System
participant Registry as Component Registry
Client->>Server: CallToolRequest (rate limit check)
alt Rate Limit Exceeded
Server-->>Client: MCP Error (429)
else Within Limit
Server->>Tool: Dispatch tool (create_react_project, add_component, etc.)
alt Template Execution Tool
Tool->>Exec: Execute shell command (placeholder substitution)
Exec-->>Tool: Command output/error
Tool->>Tool: Parse JSON (if possible)
else Direct Implementation Tool
Tool->>Exec: File system checks (package.json, ignix.config.js)
Exec-->>Tool: File existence/content
Tool->>Exec: Run ignix CLI with fallbacks
Exec-->>Tool: CLI output
end
Tool->>Registry: Query component/template data (for docs tool)
Registry-->>Tool: Registry entry
Tool->>Tool: Format structured response { isError, content }
Tool-->>Server: Response object
Server->>Server: Log to stderr (audit: timestamp, args, success, duration)
Server-->>Client: MCP Response (JSON content)
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes This diff introduces substantial new functionality across heterogeneous areas: an entire MCP server package with multiple tool implementations, a complete rewrite of the Advanced Search Form component (now using compound-component patterns with context), CLI refactoring with new initialization/status workflows, TypeScript type fixes, and comprehensive test/story coverage. While individual tool implementations and filter components follow repeatable patterns, the breadth of changes, new MCP infrastructure, and integration points between CLI→MCP→Tools require careful verification of correctness. Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release from Development
New Components or Component API Changes
AdvancedSearchFormcompound component system with multiple sub-components:SearchTextFilter,SearchSelectFilter,SearchMultiSelectFilter,SearchDateRangeFilter,SearchCheckboxFilter,SearchNumericRangeFilterSearchFilters,SearchActions,SearchSavedSearches,SearchFacetedHints,SearchResultsCount,SearchFilterRendererAdvancedSearchFormfrom provider-based architecture to compound component pattern with static properties for subcomponentsBug Fixes
ScrollAreacomponent:viewportMaskStyleto proper type inScrollAreaPrimitive.Viewportstyle propHTMLMotionProps<"div">inmotion.divcomponentTooling / Config Changes
ignix-mcp-serverpackage with:create_react_project,list_components,add_component,generate_template,validate_ignix_only,get_component_docsmcp-statuscommand to check MCP configuration across multiple clients (Cursor, Claude Desktop, VS Code, Windsurf)mcp-initcommand with new options (--dry-run,--latest,--universal) and added Windsurf client supportllms.txtwith new MCP-tools-first instructions and three-scenario workflowDocs / Storybook Updates
AdvancedSearchFormStorybook stories with 16 new stories covering:AdvancedSearchFormdocumentation with new manual installation and API referenceAdvancedSearchFormcovering rendering, interactions, accessibility, and edge casesadvanced-search-formwith template classification and dependenciesBreaking Changes
AdvancedSearchFormcomponent API completely redesigned: moved fromSearchProvider-based composable pattern withSearchHeader,SearchTabs,SearchResults,SearchPaginationto new compound component pattern with attached static subcomponentsAdvancedSearchFormreplaced; old stories (Default,WithPresets,WithThemes, etc.) removedmcp.jsontopackages/ignix-mcp-server/mcp.json; original rootmcp.jsonremoved