fix player horizontal look rotation on attach #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If vehicle `player_rotation.y` is not zero, the view must be rotated in the opposite way from the attachment rotation.
Member
|
@Panquesito7 Might you have time to look at this? I find it strange that such issue wasn't discovered earlier - was this rotation parameter never used by any of the commonly available vehicles? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If vehicle
player_rotation.yis not zero, the view must be rotated in the opposite way from the attachment rotation.I'm actually not sure why? Seems like world rotation positive direction is opposite of attachment rotation (model rotations?).
To see what this change fixes, take
vehicle_mash:car_nyan_rideand sit in it - you will be rotated 180 degrees backwards. Same with the hovercrafts, both vehicles haveplayer_rotationset to (0,90,0).