Skip to content

fix: avoid cached instance method to prevent memory leaks #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mingi3314 wants to merge 1 commit into from
Closed

fix: avoid cached instance method to prevent memory leaks #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions gapic/schema/wrappers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
import collections
import copy
import dataclasses
import functools
import json
import keyword
import re
Expand Down Expand Up @@ -1277,20 +1276,16 @@ def _to_regex(self, path_template: str) -> Pattern:
"""
return re.compile(f"^{self._convert_to_regex(path_template)}$")

# Use caching to avoid repeated computation
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2161):
# Use `@functools.cache` instead of `@functools.lru_cache` once python 3.8 is dropped.
# https://docs.python.org/3/library/functools.html#functools.cache
@functools.lru_cache(maxsize=None)
def to_regex(self) -> Pattern:
# Use caching to avoid repeated computation.
@utils.cached_property
def _regex(self) -> Pattern:
return self._to_regex(self.path_template)

@property
# Use caching to avoid repeated computation
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2161):
# Use `@functools.cache` instead of `@functools.lru_cache` once python 3.8 is dropped.
# https://docs.python.org/3/library/functools.html#functools.cache
@functools.lru_cache(maxsize=None)
def to_regex(self) -> Pattern:
return self._regex

# Use caching to avoid repeated computation.
@utils.cached_property
def key(self) -> Union[str, None]:
if self.path_template == "":
return self.field
Expand Down