Repository navigation
Log exceptions that end a thread - #53
Merged
thomas-samoht merged 1 commit intoNov 10, 2026
Merged
thomas-samoht merged 1 commit into
thomas-samoht merged 1 commit into
Conversation
ricklambrechts
previously approved these changes
Nov 9, 2026
thomas-samoht
force-pushed
the
feat/log-unhandled-thread-exceptions
branch
from
November 9, 2026 15:57
38563ee to
eb82429
Compare
thomas-samoht
changed the base branch from
main
to
fix/endpoint-route-template
November 9, 2026 15:57
ricklambrechts
previously approved these changes
Nov 9, 2026
thomas-samoht
dismissed
ricklambrechts’s stale review
November 10, 2026 08:51
The merge-base changed after approval.
thomas-samoht
force-pushed
the
feat/log-unhandled-thread-exceptions
branch
6 times, most recently
from
November 10, 2026 09:14
5c5800e to
5cbe8b3
Compare
Problem: install_excepthook() only replaced sys.excepthook, which Python calls for the main thread. An exception that ended any other thread, such as a background worker or a thread pool task, went through threading.excepthook instead, whose default prints the traceback to stderr. It never reached a stream, and nothing on the log server showed that the work had stopped. Fix: install_excepthook() also installs threading.excepthook. It logs SYS_UNHANDLED_EXCEPTION with the exception type, the thread name in the message and the traceback, on the catalogue the excepthook uses. The process keeps running after a thread ends, so it is not logged as SYS_APP_CRASHED and the shutdown reason stays as it was. SystemExit is left alone, as the default hook does. The guide mentions the new coverage.
thomas-samoht
force-pushed
the
feat/log-unhandled-thread-exceptions
branch
from
November 10, 2026 09:16
5cbe8b3 to
b850034
Compare
ricklambrechts
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install_excepthook()only replacedsys.excepthook, which Python calls only for the main thread. When an exception ended any other thread, such as a background worker or a thread pool task, Python's defaultthreading.excepthookprinted the traceback to stderr. That output went through no stream, so nothing on the log server showed that the work had stopped.install_excepthook()now also installsthreading.excepthook. It logsSYS_UNHANDLED_EXCEPTIONwith the thread name,exception_typeand the traceback. The process keeps running after a thread ends, so this is not logged asSYS_APP_CRASHEDand the shutdown reason stays unchanged.SystemExitis ignored, just as the default hook ignores it.