Included updated and created date for git docs #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucalavezzo
reviewed
Dec 19, 2025
Collaborator
lucalavezzo
left a comment
lucalavezzo
left a comment
There was a problem hiding this comment.
Thanks @juanpablosalas, minor comments, but then we can merge. I would like to pull this into #377 and build some things on top of it.
| clone_from_url = url.replace("gitlab", f"{self.git_username}:{self.git_token}@gitlab") | ||
| elif "github" in url: | ||
| clone_from_url = url.replace("github", f"{self.git_username}:{self.git_token}@github") | ||
| clone_from_url = url#.replace("github", f"{self.git_username}:{self.git_token}@github") |
Collaborator
There was a problem hiding this comment.
This is a non-trivial change in behavior, I think: didn't this allow you to pull from private repos?
| last_updated_at = self._get_last_updated_date(repo=repo, file_path=markdown_path) | ||
| resource = ScrapedResource( | ||
| url=current_url, | ||
| content=text_content, |
Collaborator
There was a problem hiding this comment.
We could think about putting the file name, date, repo, etc. in the text_content to make it easier for things like BM25 to find files via query. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by Jason, I included the last updated and created dates for files retrieved by the git scraper. This is done using the git python library and the first and last commit associated with each file.