Fix: Mitmproxy run in local mode stops working on Mac OS in an hour #7675 #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
dmitryskorbovenko
force-pushed
the
issue/7675-connection-leak
branch
2 times, most recently
from
381fed2 to
70c626c
Compare
mhils
reviewed
May 22, 2025
Member
mhils
left a comment
mhils
left a comment
There was a problem hiding this comment.
Thank you for the PR! 😃
Does this definitely fix the issues you were seeing in mitmproxy/mitmproxy#7675? Or is this a speculative fix that still needs testing?
mitmproxy-macos/redirector/network-extension/InterceptConf.swift
Outdated
Show resolved
Hide resolved
Contributor
Author
I use this in my app ui tests run every day, haven't observed "Too many open files" issue any more. |
dmitryskorbovenko
force-pushed
the
issue/7675-connection-leak
branch
from
70c626c to
476428a
Compare
mhils
approved these changes
May 29, 2025
Member
mhils
left a comment
mhils
left a comment
There was a problem hiding this comment.
Thank you! For posteriority, I believe this PR may break implementations that rely on TCP half-close. But practically speaking that is less important than the cleanup issues you described, so let's go ahead with this now and revisit if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue link mitmproxy/mitmproxy#7675