Update certificate to show issue date#3271
Conversation
OpenAPI ChangesShow/hide ## Changes for v0.yaml:Unexpected changes? Ensure your branch is up-to-date with |
rachellougee
left a comment
rachellougee
left a comment
There was a problem hiding this comment.
The certificate now displays issue_date when it's set, but shows empty when it isn't. Since issue_date is not required, we should add a default value.
| "learner_name": self.certificate.user.get_full_name(), | ||
| "start_date": start_date, | ||
| "end_date": end_date, | ||
| "issue_date": self.certificate.issue_date, |
There was a problem hiding this comment.
This works if issue_date is set, but over 2000 certificates don't have an issue_date, can we add a default? maybe created_on?
e.g. https://mitxonline.mit.edu/admin/courses/courseruncertificate/59293/change/
annagav
force-pushed
the
ag/issue_date
branch
3 times, most recently
from
f9e8cdb to
c1b248e
Compare
| for certificate in CourseRunCertificate.objects.all(): | ||
| if certificate.issue_date is None: | ||
| certificate.issue_date = certificate.created_on | ||
| certificate.save(update_fields=["issue_date"]) |
There was a problem hiding this comment.
Just a suggestion for performance: this can be done in one query. But since you've handled similar migration before, its likely fine as is
CourseRunCertificate.objects.filter(
issue_date__isnull=True
).update(issue_date=models.F("created_on"))
for more information, see https://pre-commit.ci
annagav
force-pushed
the
ag/issue_date
branch
from
f6dd507 to
4f395c0
Compare
for more information, see https://pre-commit.ci
rachellougee
left a comment
rachellougee
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the change.
2 participants
What are the relevant tickets?
Related to https://github.com/mitodl/mitxonline/pull/3025/changes
Description (What does it do?)
Update certificate to show issue date
Screenshots (if appropriate):
How can this be tested?
Created a certificate, go to view it
Make sure that the date shown is the issue date.