Fix duplicate engagement rows from non-unique course_number join in mitxonline_course_engagements_daily_report#1918
Merged
quazi-h merged 2 commits intoFeb 20, 2026
Conversation
…to avoid duplicates Co-authored-by: quazi-h <59845076+quazi-h@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback on mitxonline course engagements daily report PR
Fix duplicate engagement rows from non-unique course_number join in mitxonline_course_engagements_daily_report
Feb 20, 2026
quazi-h
approved these changes
Feb 20, 2026
quazi-h
merged commit bf52232
into
mitxonline-course-engagements-daily-report
2 checks passed
quazi-h
added a commit
that referenced
this pull request
Feb 27, 2026
…itxonline_course_engagements_daily_report (#1918) * Initial plan * Fix course join to use mitxonline_course_id instead of course_number to avoid duplicates Co-authored-by: quazi-h <59845076+quazi-h@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: quazi-h <59845076+quazi-h@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
int__mitx__coursesis not guaranteed unique oncourse_number(e.g. UAI courses), so joining directly on that field could fan out engagement rows and inflate metrics.Changes
mitxonline_course_runsCTE sourced fromint__mitxonline__course_runsto bridge engagements → integer course IDcourse_numberjoin withmitxonline_course_id— a unique integer FK — eliminating the duplication risk🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.