Fix courserun_is_current logic and select * in mitxonline_course_engagements_daily_report

[Copilot]

Two correctness/hygiene issues in the mitxonline_course_engagements_daily_report model.

Changes

• mitx_courses CTE: Replace select * with explicit column selection (mitxonline_course_id, course_readable_id) to reduce scan cost and decouple from upstream schema changes.

• courserun_is_current: Align computation with int__combined__course_runs — use from_iso8601_timestamp() instead of cast(substring(..., 1, 10) as date), and use an exclusive end boundary (> current_date) rather than inclusive (>= current_date). This avoids off-by-one behavior for runs ending at midnight and keeps "current" semantics consistent across the project.

-- Before
case
    when cast(substring(courserun_start_on, 1, 10) as date) <= current_date
        and (courserun_end_on is null
            or cast(substring(courserun_end_on, 1, 10) as date) >= current_date)
        then true
    else false
end as courserun_is_current

-- After (matches int__combined__course_runs pattern)
case
    when courserun_end_on is null
        and from_iso8601_timestamp(courserun_start_on) <= current_date
        then true
    when from_iso8601_timestamp(courserun_start_on) <= current_date
        and from_iso8601_timestamp(courserun_end_on) > current_date
        then true
    else false
end as courserun_is_current

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.