Skip to content

Fix mitxonline_course_engagements_daily_report: safe course join, iso8601 timestamps, selective CTE columns#1928

Merged
quazi-h merged 2 commits into
mitxonline-course-engagements-daily-reportfrom
copilot/sub-pr-1906
Feb 23, 2026
Merged

Fix mitxonline_course_engagements_daily_report: safe course join, iso8601 timestamps, selective CTE columns#1928
quazi-h merged 2 commits into
mitxonline-course-engagements-daily-reportfrom
copilot/sub-pr-1906

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 20, 2026

  • Replace mitxonline_engagements.* with explicit column references in the final SELECT to align with codebase conventions and reduce coupling to upstream schema changes

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

@quazi-h
Copy link
Copy Markdown
Contributor

quazi-h commented Feb 20, 2026

@copilot there are no code changes here...

Copilot AI changed the title [WIP] Add mitxonline course engagements daily report Fix mitxonline_course_engagements_daily_report: safe course join, iso8601 timestamps, selective CTE columns Feb 20, 2026
Copilot AI requested a review from quazi-h February 20, 2026 21:35
…ts_daily_report

Co-authored-by: quazi-h <59845076+quazi-h@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Feb 20, 2026

@copilot there are no code changes here...

Added an explicit column list in the final SELECT to replace mitxonline_engagements.*, aligning with the codebase pattern used by other reporting models (e.g., video_engagement_report.sql) and reducing coupling to upstream schema changes. Commit: 13c709f

@quazi-h quazi-h marked this pull request as ready for review February 23, 2026 13:59
@quazi-h quazi-h merged commit 6e83c79 into mitxonline-course-engagements-daily-report Feb 23, 2026
2 checks passed
@quazi-h quazi-h deleted the copilot/sub-pr-1906 branch February 23, 2026 14:00
quazi-h added a commit that referenced this pull request Feb 27, 2026
…8601 timestamps, selective CTE columns (#1928)

* Initial plan

* Replace select * with explicit columns in mitxonline_course_engagements_daily_report

Co-authored-by: quazi-h <59845076+quazi-h@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: quazi-h <59845076+quazi-h@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants