Revert fix: use PyArrowFileIO for S3 access in get_dbt_model_as_dataframe#2222
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts PR #2218 by removing the explicit PyIceberg GlueCatalog py-io-impl override intended to force PyArrowFileIO for S3 reads in get_dbt_model_as_dataframe.
Changes:
- Removes the explicit
py-io-impl: pyiceberg.io.pyarrow.PyArrowFileIOconfiguration when constructingGlueCatalog. - Updates the
get_dbt_model_as_dataframedocstring to describe a DataFrame return type and adjusts documented exceptions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Reverts PR #2218.
The
py-io-impl: pyiceberg.io.pyarrow.PyArrowFileIOproperty added in #2218is redundant — PyIceberg 0.11.1 already prefers PyArrowFileIO for S3 paths
by default (see SCHEMA_TO_FILE_IO in pyiceberg/io/init.py). The explicit
setting has no effect and is dead code.
Description (What does it do?)
Screenshots (if appropriate):
How can this be tested?
Additional Context