Open
Conversation
Owner
|
Great work. I am going to merge your pull request once I find some spare time. |
Author
|
Thank you for all the time and effort you've invested into existing tests. It made my work on refactoring much easier! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found some bugs in TSIP frame decoder. It was handling edge cases around packets ending with
<DLE>incorrectly.I added some tests and refactored the code to pass the tests.
Our hackerspace has recently got a dozen of ICM SMT 360 timing receivers, so I'll likely submit some more code soon, as I start working with the actual device.