-
Notifications
You must be signed in to change notification settings - Fork 597
[LoadGen] Simplify installation with a pip one-liner #2396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[LoadGen] Simplify installation with a pip one-liner #2396
Conversation
…m:CentML/mlperf-inference into wangshangsam/loadgen-build-during-install
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
@pgmpablo157321 @arjunsuresh @mrmhodak @hanyunfan I wondering if you could review this PR and see if you are open to such a change in the LoadGen's installation process? |
|
@wangshangsam The changes look fine to me but |
The
in https://github.com/mlcommons/inference/blob/master/loadgen/README_BUILD.md made me think that the package in pypi is not updated as frequently, but then I just took a look at the commit histroy again, and it does seem that |
|
Yes. We need to update the readme. The pypi release is done automatically via GitHub action. @anandhu-eng can you please update the loadgen readme? https://github.com/mlcommons/inference/blob/master/.github/workflows/build_wheels.yml |
|
Hey everyone, I have raised a PR here: #2398 |
This PR essentially:
CFLAGS="-std=c++14 -O3"intosetup.pyasextra_compile_args.absl-pyandnumpydependencies intorequirements.txt, then enablesetup.pyto read fromrequirements.txt.Therefore, this PR enables one-liner installation of LoadGen from the top of the
masterbranch without the need to cloning the repo first:The motivation I had is that, in the
pyproject.tomlof the specific benchmark (e.g.,multimodal/vl2l), now I can just addmlcommons_loadgen @ git+https://github.com/mlcommons/inference.git#subdirectory=loadgenas a dependency, then I don't need a separate step to build/install the LoadGen first before installing the benchmark, thereby achieving an one-liner installation of the benchmark too:cc @johncalesp @nvzhihanj