Add accuracy_sample_count #2414
Open
+48
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
v-shobhit
force-pushed
the
shobhitv/acc_sample_count
branch
from
865c33b to
3f2f719
Compare
Contributor
|
@pgmpablo157321 @tanvi-mlcommons @mrmhodak please help review this PR - the accuracy sample count is something new we add to separate the accuracy and performance test dataset. Can you help review and suggest what else is needed for this feature? |
Contributor
|
@pgmpablo157321: Please take a look to see if you agree with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future, benchmarks (like gpt-oss) may have separate perf and accuracy datasets
This PR adds a separate config field,
accuracy_sample_count, to set the number of samples in the acc eval dataset - separate from the existingperformance_sample_countwhich will be used for the size of the perf eval dataset.This new field defaults to
performance_sample_countfor backwards compatibility.