Skip to content

Remove unused fields triggeredBy_ and hasUnreportedChange_ - #4779

Merged
kubk merged 1 commit into
mobxjs:mainfrom
kubk:remove-dead-fields
Nov 13, 2026
Merged

kubk merged 1 commit into
mobxjs:mainfrom
kubk:remove-dead-fields

Conversation

@kubk

@kubk kubk commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Removes unused private fields

@changeset-bot

changeset-bot Bot commented Nov 13, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c1c15e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mobx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified, and the obsolete fields, related assertions, and changeset have been updated consistently.

No open issues 🎉

What changed in this PR

This PR removes two unused internal MobX fields, updates related white-box tests, and documents the cleanup in a patch changeset.

Changes:

  • Removes ObservableValue.hasUnreportedChange_.
  • Removes ComputedValue.triggeredBy_.
  • Deletes obsolete assertions and adds a patch changeset.
File Description
packages/​mobx/​src/​types/​observablevalue.ts Removes the unused hasUnreportedChange_ field from ObservableValue.
packages/​mobx/​src/​core/​computedvalue.ts Removes the unused triggeredBy_ field from ComputedValue.
packages/​mobx/​__tests__/​base/​errorhandling.js Removes obsolete assertions for the deleted observable field.
.changeset/​remove-dead-fields.md Documents the internal cleanup in a patch release changeset.

Review effort: Lite

@kubk
kubk merged commit 410d1fa into mobxjs:main Nov 13, 2026
1 check passed
@github-actions github-actions Bot mentioned this pull request Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants