Repository navigation
Remove unused fields triggeredBy_ and hasUnreportedChange_ - #4779
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: c1c15e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified, and the obsolete fields, related assertions, and changeset have been updated consistently.
No open issues 🎉
What changed in this PR
This PR removes two unused internal MobX fields, updates related white-box tests, and documents the cleanup in a patch changeset.
Changes:
- Removes
ObservableValue.hasUnreportedChange_. - Removes
ComputedValue.triggeredBy_. - Deletes obsolete assertions and adds a patch changeset.
| File | Description |
|---|---|
| packages/mobx/src/types/observablevalue.ts | Removes the unused hasUnreportedChange_ field from ObservableValue. |
| packages/mobx/src/core/computedvalue.ts | Removes the unused triggeredBy_ field from ComputedValue. |
| packages/mobx/__tests__/base/errorhandling.js | Removes obsolete assertions for the deleted observable field. |
| .changeset/remove-dead-fields.md | Documents the internal cleanup in a patch release changeset. |
Review effort: Lite
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unused private fields