Tests: Use custom docker/podman network, rework provisioning of containers, and more tweaks #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhusar
reviewed
Nov 11, 2025
jajik
force-pushed
the
issue-348
branch
2 times, most recently
from
077e824 to
ef99b9f
Compare
jfclere
requested changes
Nov 13, 2025
Member
jfclere
left a comment
jfclere
left a comment
There was a problem hiding this comment.
The problem is more the mix of variable set + call of function on the same line and variable set in several line and then the call of the function. We should use a single one and prefer a single line set + calls (more easy to maintain.
Set HostNameLookups On to get hostname in %{REMOTE_HOST}, no IP
Drop hardcoded IP addresses, no localhost (except client <-> proxy)
Tomcat container now does not exit when tomcat process is stopped
Minor files & format clean ups
Containers are now using custom docker network with DNS Containers are now using their container names instead of localhost/IPs Parameters/Options now reflect the actual usage
Shift tomcat ports where conflicts might lead to random test failures Code and format clean ups
Also test a little bit more than before UseAlias is not enabled by default in the rest of the testsuite now
Unfortunately, custom podman networks do not support rDNS so tomcat requests are handled by their IP. This causes our `Require host` to not work which leads to test failures. Upon httpd container start, we try to detect podman and if needed, we change `Require host` to `Require ip`.
Before all configuration variables will be moved at the beginning.
Member
Author
|
(rebase) |
Member
Author
|
Thanks for the review! |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bigger PR but because of the nature of changes, there is not much what to do about it (I've already dropped some changes for future PRs).
The main thing is that host network is no longer used in containerized tests. This allows us to use DNS, isolate tests to a different network (minimizing conflicts with other running services).
In points:
close #348