-
Notifications
You must be signed in to change notification settings - Fork 568
Update to MTP #958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update to MTP #958
Conversation
tests/ModelContextProtocol.AspNetCore.Tests/ModelContextProtocol.AspNetCore.Tests.csproj
Outdated
Show resolved
Hide resolved
|
@stephentoub This hopefully should be green. |
| https://xunit.net/docs/getting-started/v3/microsoft-testing-platform | ||
| --> | ||
| <DisableTestingPlatformServerCapability>true</DisableTestingPlatformServerCapability> | ||
| </PropertyGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this issue addressed with MTP?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure of the issue you were facing. Worst case if you can still repro, we can add this property back (this property only affects Test Explorer and doesn't affect command-line, so all other work done in this PR can remain).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephentoub Do you think what you saw is the same as https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2540441 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks likely
Is this a flaky test? |
Probably |
Motivation and Context
Keep the test infra up-to-date with the latest dependencies and moving away from VSTest to the newer Microsoft.Testing.Platform.
How Has This Been Tested?
Manually running tests locally (still not working, that's why it's draft)
Breaking Changes
Types of changes
Checklist
Additional context